From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56694) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3Uha-0001Wv-BX for qemu-devel@nongnu.org; Sun, 28 Jul 2013 13:24:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3UhU-0006gu-Od for qemu-devel@nongnu.org; Sun, 28 Jul 2013 13:24:14 -0400 Received: from cantor2.suse.de ([195.135.220.15]:37054 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3UhU-0006fw-Ii for qemu-devel@nongnu.org; Sun, 28 Jul 2013 13:24:08 -0400 Message-ID: <51F553B3.5070409@suse.de> Date: Sun, 28 Jul 2013 19:24:03 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1374996553-21828-1-git-send-email-imammedo@redhat.com> <1374996553-21828-3-git-send-email-imammedo@redhat.com> <51F4EAFA.3070106@suse.de> <20130728192145.67ede786@thinkpad> In-Reply-To: <20130728192145.67ede786@thinkpad> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/6] pc: add I440FX QOM cast macro List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, mst@redhat.com Am 28.07.2013 19:21, schrieb Igor Mammedov: > On Sun, 28 Jul 2013 11:57:14 +0200 > Andreas F=E4rber wrote: >=20 >> Am 28.07.2013 09:29, schrieb Igor Mammedov: >>> Signed-off-by: Igor Mammedov >>> --- >>> hw/pci-host/piix.c | 8 ++++++-- >>> 1 file changed, 6 insertions(+), 2 deletions(-) >>> >>> diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c >>> index 3908860..bf879e7 100644 >>> --- a/hw/pci-host/piix.c >>> +++ b/hw/pci-host/piix.c >>> @@ -38,6 +38,10 @@ >>> * http://download.intel.com/design/chipsets/datashts/29054901.pdf >>> */ >>> =20 >>> +#define TYPE_I440FX_PCI_HOST "i440FX-pcihost" >>> +#define I440FX_PCI_HOST(obj) \ >>> + OBJECT_CHECK(I440FXState, (obj), TYPE_I440FX_PCI_HOST) >> >> Either Anthony or mst had insisted on PCI_HOST_BRIDGE rather than >> PCI_HOST. Other than that looks good, thanks! >=20 > it's the type cast macro that is missing, so adding it shouldn't hurt, > and some day in future we might any way need to add it even if we don't= use it > now. Maybe you misunderstood? Please add _BRIDGE to your macros. :) Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg