From: "Andreas Färber" <afaerber@suse.de>
To: Igor Mammedov <imammedo@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, Gleb Natapov <gleb@redhat.com>,
kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH qom-cpu v9] target-i386: Move hyperv_* static globals to X86CPU
Date: Sun, 28 Jul 2013 22:34:41 +0200 [thread overview]
Message-ID: <51F58061.5020509@suse.de> (raw)
In-Reply-To: <20130708144054.36655c55@nial.usersys.redhat.com>
Am 08.07.2013 14:40, schrieb Igor Mammedov:
> On Mon, 8 Jul 2013 03:03:54 +0200
> Andreas Färber <afaerber@suse.de> wrote:
>
>> From: Igor Mammedov <imammedo@redhat.com>
>>
>> - since hyperv_* helper functions are used only in target-i386/kvm.c
>> move them there as static helpers
>>
>> Requested-by: Eduardo Habkost <ehabkost@redhat.com>
>> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
> I'm not tested it yet, but it looks good to me.
Being from you originally and me having confidence in my changes on top,
I'm queuing this on qom-cpu-next:
https://github.com/afaerber/qemu-cpu/commits/qom-cpu-next
Andreas
>> ---
>> v8 (imammedo) -> v9:
>> * Use X86CPU instead of CPUX86State (only used in KVM)
>> * Changed helper functions to X86CPU argument
>> * Moved field initialization to QOM instance_init
>> * Fixed subject (not today's "CPUState")
>>
>> target-i386/Makefile.objs | 2 +-
>> target-i386/cpu-qom.h | 4 +++
>> target-i386/cpu.c | 16 ++++++++----
>> target-i386/cpu.h | 4 +++
>> target-i386/hyperv.c | 64 -----------------------------------------------
>> target-i386/hyperv.h | 45 ---------------------------------
>> target-i386/kvm.c | 36 ++++++++++++++++++--------
>> 7 files changed, 46 insertions(+), 125 deletions(-)
>> delete mode 100644 target-i386/hyperv.c
>> delete mode 100644 target-i386/hyperv.h
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber@suse.de>
To: Igor Mammedov <imammedo@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, Gleb Natapov <gleb@redhat.com>,
kvm <kvm@vger.kernel.org>
Subject: Re: [Qemu-devel] [PATCH qom-cpu v9] target-i386: Move hyperv_* static globals to X86CPU
Date: Sun, 28 Jul 2013 22:34:41 +0200 [thread overview]
Message-ID: <51F58061.5020509@suse.de> (raw)
In-Reply-To: <20130708144054.36655c55@nial.usersys.redhat.com>
Am 08.07.2013 14:40, schrieb Igor Mammedov:
> On Mon, 8 Jul 2013 03:03:54 +0200
> Andreas Färber <afaerber@suse.de> wrote:
>
>> From: Igor Mammedov <imammedo@redhat.com>
>>
>> - since hyperv_* helper functions are used only in target-i386/kvm.c
>> move them there as static helpers
>>
>> Requested-by: Eduardo Habkost <ehabkost@redhat.com>
>> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
> I'm not tested it yet, but it looks good to me.
Being from you originally and me having confidence in my changes on top,
I'm queuing this on qom-cpu-next:
https://github.com/afaerber/qemu-cpu/commits/qom-cpu-next
Andreas
>> ---
>> v8 (imammedo) -> v9:
>> * Use X86CPU instead of CPUX86State (only used in KVM)
>> * Changed helper functions to X86CPU argument
>> * Moved field initialization to QOM instance_init
>> * Fixed subject (not today's "CPUState")
>>
>> target-i386/Makefile.objs | 2 +-
>> target-i386/cpu-qom.h | 4 +++
>> target-i386/cpu.c | 16 ++++++++----
>> target-i386/cpu.h | 4 +++
>> target-i386/hyperv.c | 64 -----------------------------------------------
>> target-i386/hyperv.h | 45 ---------------------------------
>> target-i386/kvm.c | 36 ++++++++++++++++++--------
>> 7 files changed, 46 insertions(+), 125 deletions(-)
>> delete mode 100644 target-i386/hyperv.c
>> delete mode 100644 target-i386/hyperv.h
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-07-28 20:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 1:03 [PATCH qom-cpu v9] target-i386: Move hyperv_* static globals to X86CPU Andreas Färber
2013-07-08 1:03 ` [Qemu-devel] " Andreas Färber
2013-07-08 12:40 ` Igor Mammedov
2013-07-08 12:40 ` Igor Mammedov
2013-07-28 20:34 ` Andreas Färber [this message]
2013-07-28 20:34 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F58061.5020509@suse.de \
--to=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=gleb@redhat.com \
--cc=imammedo@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.