From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1V3giT-00019P-Ej for mharc-qemu-trivial@gnu.org; Mon, 29 Jul 2013 02:13:57 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48741) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3giM-0000xS-N5 for qemu-trivial@nongnu.org; Mon, 29 Jul 2013 02:13:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3giG-0005me-Mu for qemu-trivial@nongnu.org; Mon, 29 Jul 2013 02:13:50 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:41801) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3gi5-0005lS-Ps; Mon, 29 Jul 2013 02:13:33 -0400 Received: from [192.168.88.2] (mjt.vpn.tls.msk.ru [192.168.177.99]) by isrv.corpit.ru (Postfix) with ESMTP id 71E744313A; Mon, 29 Jul 2013 10:13:32 +0400 (MSK) Message-ID: <51F6080B.30904@msgid.tls.msk.ru> Date: Mon, 29 Jul 2013 10:13:31 +0400 From: Michael Tokarev Organization: Telecom Service, JSC User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130704 Icedove/17.0.7 MIME-Version: 1.0 To: Aurelien Jarno References: <1374783031-26633-1-git-send-email-sw@weilnetz.de> <20130728223710.GF10155@hall.aurel32.net> In-Reply-To: <20130728223710.GF10155@hall.aurel32.net> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 86.62.121.231 Cc: qemu-trivial , Stefan Weil , qemu-devel Subject: Re: [Qemu-trivial] [PATCH] target-mips: Remove assignment to a variable which is never used X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jul 2013 06:13:55 -0000 On 29.07.2013 02:37, Aurelien Jarno wrote: > On Thu, Jul 25, 2013 at 10:10:31PM +0200, Stefan Weil wrote: >> This assignment causes a compiler warning for compilations with the compiler >> option -Wunused-but-set-variable (which is included with -Wextra). >> >> Removing it allows using -Wextra for QEMU code without suppressing too many >> extra warnings. >> >> Signed-off-by: Stefan Weil >> --- >> target-mips/op_helper.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c >> index 5cf1c3f..b828375 100644 >> --- a/target-mips/op_helper.c >> +++ b/target-mips/op_helper.c >> @@ -1735,7 +1735,6 @@ target_ulong helper_evpe(CPUMIPSState *env) >> void helper_fork(target_ulong arg1, target_ulong arg2) >> { >> // arg1 = rt, arg2 = rs >> - arg1 = 0; >> // TODO: store to TC register >> } > > Thanks, applied. FWIW, you're applying this (and "linux-user: correct argument number ..") 3 days after I sent a pull request for trivial-patches which includes these patches. Should I rebase and re-issue my pull request now? Thanks, /mjt From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48685) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3giA-0000nn-SW for qemu-devel@nongnu.org; Mon, 29 Jul 2013 02:13:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3gi6-0005lW-1B for qemu-devel@nongnu.org; Mon, 29 Jul 2013 02:13:38 -0400 Message-ID: <51F6080B.30904@msgid.tls.msk.ru> Date: Mon, 29 Jul 2013 10:13:31 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1374783031-26633-1-git-send-email-sw@weilnetz.de> <20130728223710.GF10155@hall.aurel32.net> In-Reply-To: <20130728223710.GF10155@hall.aurel32.net> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] target-mips: Remove assignment to a variable which is never used List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-trivial , Stefan Weil , qemu-devel On 29.07.2013 02:37, Aurelien Jarno wrote: > On Thu, Jul 25, 2013 at 10:10:31PM +0200, Stefan Weil wrote: >> This assignment causes a compiler warning for compilations with the compiler >> option -Wunused-but-set-variable (which is included with -Wextra). >> >> Removing it allows using -Wextra for QEMU code without suppressing too many >> extra warnings. >> >> Signed-off-by: Stefan Weil >> --- >> target-mips/op_helper.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c >> index 5cf1c3f..b828375 100644 >> --- a/target-mips/op_helper.c >> +++ b/target-mips/op_helper.c >> @@ -1735,7 +1735,6 @@ target_ulong helper_evpe(CPUMIPSState *env) >> void helper_fork(target_ulong arg1, target_ulong arg2) >> { >> // arg1 = rt, arg2 = rs >> - arg1 = 0; >> // TODO: store to TC register >> } > > Thanks, applied. FWIW, you're applying this (and "linux-user: correct argument number ..") 3 days after I sent a pull request for trivial-patches which includes these patches. Should I rebase and re-issue my pull request now? Thanks, /mjt