From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Holler Subject: Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT Date: Mon, 29 Jul 2013 12:27:35 +0200 Message-ID: <51F64397.2090107@ahsoftware.de> References: <1372433223-9053-1-git-send-email-javier.martinez@collabora.co.uk> <51F4F973.8000303@ahsoftware.de> <51F515A9.9010005@ahsoftware.de> <448912EABC71F84BBCADFD3C67C4BE5283E9D4@DBDE04.ent.ti.com> <51F60E81.7090103@ahsoftware.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from h1446028.stratoserver.net ([85.214.92.142]:46970 "EHLO mail.ahsoftware.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753595Ab3G2K20 (ORCPT ); Mon, 29 Jul 2013 06:28:26 -0400 Received: from eiche.ahsoftware (p57B216E0.dip0.t-ipconnect.de [87.178.22.224]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.ahsoftware.de (Postfix) with ESMTPSA id 41633423C272 for ; Mon, 29 Jul 2013 12:28:24 +0200 (CEST) In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Javier Martinez Canillas Cc: Linus Walleij , "Shilimkar, Santosh" , ext Tony Lindgren , Grant Likely , Kevin Hilman , Javier Martinez Canillas , Jon Hunter , Jean-Christophe PLAGNIOL-VILLARD , Enric Balletbo Serra , Linux-OMAP , Florian Vaussard , Aaro Koskinen , "Krishnamoorthy, Balaji T" Am 29.07.2013 10:17, schrieb Javier Martinez Canillas: > Hi Alexander, > > On Mon, Jul 29, 2013 at 8:41 AM, Alexander Holler wrote: >> Am 28.07.2013 21:06, schrieb Javier Martinez Canillas: >> >>> On Sun, Jul 28, 2013 at 8:22 PM, Linus Walleij >>> wrote: >>>> >>>> On Sun, Jul 28, 2013 at 7:33 PM, Javier Martinez Canillas >>>> wrote: >>>> >>>>> According to Documentation/devicetree/bindings/mmc/mmc.txt: >>>>> >>>>> cd-gpios: Specify GPIOs for card detection, see gpio binding >>>>> >>>>> So it just says that it is a GPIO for card detection and not an IRQ so >>>>> this assumption comes from either the omap_hsmmc driver or Alexander' >>>>> DTS is missing something like: >>>>> >>>>> interrupt-parent = <&gpio6>; >>>>> interrupts = <16 8>; >> >> >> What do the values 16 and 8 mean here? GPIO numbers? >> And where do I have to place that? >> > > If you look at Documentation/devicetree/bindings/interrupt-controller/interrupts.txt > for the two cells interrupt controllers definition: > > b) two cells > ------------ > The #interrupt-cells property is set to 2 and the first cell defines the > index of the interrupt within the controller, while the second cell is used I had read that. And there is written, "index of the interrupt". So may I ask the question how you think people are translating GPIO number to interrupt index?. And if it's the same, will GPIO0_0 map to IRQ 0 or how is the magic formular people are supposed to use? Besides that, the existing standard DTS I've modified into my "non-standard" dts is arch/arm/boot/dts/am335x-bone.dts. if you look at the definition of the GPIO bank 0 in arch/arm/boot/dts/am33xx.dtsi, you see #interrupt-cells = <1>; Anyway, thanks for your time, but I don't want to spend more time on that topic. Regards, Alexander Holler