From: John Crispin <john@phrozen.org>
To: Florian Fainelli <florian@openwrt.org>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: add proper set_mode() to cevt-r4k
Date: Mon, 29 Jul 2013 13:14:35 +0200 [thread overview]
Message-ID: <51F64E9B.8070306@phrozen.org> (raw)
In-Reply-To: <CAGVrzcYcP8kUueLkDtL+fT9g+HFUKGgdw_hTRXkhA8P+4LbL8A@mail.gmail.com>
>> the actual problem is not the irq sharing but that the cevt-r4k registers
>> the irq when the cevt is registered and not when it is activated. i believe
>> that the patch fixes this problem
>
> Your patch certainly does what you say it does, but that is kind of an
> abuse of the set_mode() callback.
well there are 2 modes "run as oneshot timer and dont run. i dont see
how this is an abuse?
next prev parent reply other threads:[~2013-07-29 11:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 9:55 [PATCH] MIPS: add proper set_mode() to cevt-r4k John Crispin
2013-07-29 10:40 ` Florian Fainelli
2013-07-29 10:52 ` John Crispin
2013-07-29 11:14 ` Florian Fainelli
2013-07-29 11:14 ` John Crispin [this message]
2013-07-30 10:01 ` Florian Fainelli
2013-07-31 19:22 ` David Daney
2013-07-31 19:26 ` Florian Fainelli
2013-08-01 6:15 ` John Crispin
2013-08-01 14:13 ` Ralf Baechle
2013-08-01 14:16 ` John Crispin
2013-07-29 14:53 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F64E9B.8070306@phrozen.org \
--to=john@phrozen.org \
--cc=florian@openwrt.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.