diff for duplicates of <51F64EC0.800@nvidia.com> diff --git a/a/1.txt b/N1/1.txt index 45abf92..c2e7160 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -13,7 +13,7 @@ On 07/27/2013 11:38 PM, Jean Delvare wrote: > Let me review it nevertheless: > >> ->> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> +>> Signed-off-by: Wei Ni <wni@nvidia.com> >> --- >> drivers/hwmon/lm90.c | 179 ++++++++++++++++++++++++++++++++------------------ >> 1 file changed, 114 insertions(+), 65 deletions(-) @@ -182,7 +182,7 @@ use numbers. >> + &data->temp11[TEMP11_LOCAL_TEMP]); >> } else { >> if (lm90_read_reg(client, LM90_REG_R_LOCAL_TEMP, ->> &h) == 0) +>> &h) = 0) >> - data->temp11[4] = h << 8; >> + data->temp11[TEMP11_LOCAL_TEMP] = h << 8; >> } @@ -197,33 +197,32 @@ Yes, I will do it. > >> ->> if (lm90_read_reg(client, LM90_REG_R_REMOTE_LOWH, &h) == 0) { +>> if (lm90_read_reg(client, LM90_REG_R_REMOTE_LOWH, &h) = 0) { >> - data->temp11[1] = h << 8; >> + data->temp11[TEMP11_REMOTE_LOW] = h << 8; >> if ((data->flags & LM90_HAVE_REM_LIMIT_EXT) >> && lm90_read_reg(client, LM90_REG_R_REMOTE_LOWL, ->> &l) == 0) +>> &l) = 0) >> - data->temp11[1] |= l; >> + data->temp11[TEMP11_REMOTE_LOW] |= l; >> } ->> if (lm90_read_reg(client, LM90_REG_R_REMOTE_HIGHH, &h) == 0) { +>> if (lm90_read_reg(client, LM90_REG_R_REMOTE_HIGHH, &h) = 0) { >> - data->temp11[2] = h << 8; >> + data->temp11[TEMP11_REMOTE_HIGH] = h << 8; >> if ((data->flags & LM90_HAVE_REM_LIMIT_EXT) >> && lm90_read_reg(client, LM90_REG_R_REMOTE_HIGHL, ->> &l) == 0) +>> &l) = 0) >> - data->temp11[2] |= l; >> + data->temp11[TEMP11_REMOTE_HIGH] |= l; >> } >> >> if (data->flags & LM90_HAVE_OFFSET) { >> @@ -529,13 +570,14 @@ static struct lm90_data *lm90_update_device(struct device *dev) ->> &h) == 0 +>> &h) = 0 >> && lm90_read_reg(client, LM90_REG_R_REMOTE_OFFSL, ->> &l) == 0) +>> &l) = 0) >> - data->temp11[3] = (h << 8) | l; ->> + data->temp11[TEMP11_REMOTE_OFFSET] = ->> + (h << 8) | l; +>> + data->temp11[TEMP11_REMOTE_OFFSET] >> + (h << 8) | l; >> } >> if (data->flags & LM90_HAVE_EMERGENCY) { >> lm90_read_reg(client, MAX6659_REG_R_LOCAL_EMERG, @@ -236,7 +235,7 @@ Yes, I will do it. >> lm90_read_reg(client, LM90_REG_R_STATUS, &alarms); >> data->alarms = alarms; /* save as 16 bit value */ >> @@ -543,15 +585,16 @@ static struct lm90_data *lm90_update_device(struct device *dev) ->> if (data->kind == max6696) { +>> if (data->kind = max6696) { >> lm90_select_remote_channel(client, data, 1); >> lm90_read_reg(client, LM90_REG_R_REMOTE_CRIT, >> - &data->temp8[6]); @@ -281,14 +280,14 @@ Yes, I will do it. >> @@ -919,11 +962,12 @@ static ssize_t set_temphyst(struct device *dev, struct device_attribute *dummy, >> >> mutex_lock(&data->update_lock); ->> if (data->kind == adt7461) +>> if (data->kind = adt7461) >> - temp = temp_from_u8_adt7461(data, data->temp8[2]); >> + temp = temp_from_u8_adt7461(data, >> + data->temp8[TEMP8_LOCAL_CRIT]); > > Please align on opening parenthesis. > ->> else if (data->kind == max6646) +>> else if (data->kind = max6646) >> - temp = temp_from_u8(data->temp8[2]); >> + temp = temp_from_u8(data->temp8[TEMP8_LOCAL_CRIT]); >> else @@ -406,4 +405,10 @@ Wei. > > -- > Jean Delvare -> +> + + +_______________________________________________ +lm-sensors mailing list +lm-sensors@lm-sensors.org +http://lists.lm-sensors.org/mailman/listinfo/lm-sensors diff --git a/a/content_digest b/N1/content_digest index 68d63e6..ad08f7e 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,9 +2,9 @@ "ref\01373615287-18502-5-git-send-email-wni@nvidia.com\0" "ref\020130727173830.14cb5b21@endymion.delvare\0" "ref\020130727173830.14cb5b21-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org\0" - "From\0Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\0" - "Subject\0Re: [PATCH v3 4/4] hwmon: (lm90) use enums for the indexes of temp8 and temp11\0" - "Date\0Mon, 29 Jul 2013 19:15:12 +0800\0" + "From\0Wei Ni <wni@nvidia.com>\0" + "Subject\0Re: [lm-sensors] [PATCH v3 4/4] hwmon: (lm90) use enums for the indexes of temp8 and temp11\0" + "Date\0Mon, 29 Jul 2013 11:15:12 +0000\0" "To\0Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>\0" "Cc\0linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>" thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @@ -28,7 +28,7 @@ "> Let me review it nevertheless:\n" "> \n" ">>\n" - ">> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\n" + ">> Signed-off-by: Wei Ni <wni@nvidia.com>\n" ">> ---\n" ">> drivers/hwmon/lm90.c | 179 ++++++++++++++++++++++++++++++++------------------\n" ">> 1 file changed, 114 insertions(+), 65 deletions(-)\n" @@ -197,7 +197,7 @@ ">> + &data->temp11[TEMP11_LOCAL_TEMP]);\n" ">> } else {\n" ">> if (lm90_read_reg(client, LM90_REG_R_LOCAL_TEMP,\n" - ">> &h) == 0)\n" + ">> &h) = 0)\n" ">> - data->temp11[4] = h << 8;\n" ">> + data->temp11[TEMP11_LOCAL_TEMP] = h << 8;\n" ">> }\n" @@ -212,33 +212,32 @@ "\n" "> \n" ">>\n" - ">> if (lm90_read_reg(client, LM90_REG_R_REMOTE_LOWH, &h) == 0) {\n" + ">> if (lm90_read_reg(client, LM90_REG_R_REMOTE_LOWH, &h) = 0) {\n" ">> - data->temp11[1] = h << 8;\n" ">> + data->temp11[TEMP11_REMOTE_LOW] = h << 8;\n" ">> if ((data->flags & LM90_HAVE_REM_LIMIT_EXT)\n" ">> && lm90_read_reg(client, LM90_REG_R_REMOTE_LOWL,\n" - ">> &l) == 0)\n" + ">> &l) = 0)\n" ">> - data->temp11[1] |= l;\n" ">> + data->temp11[TEMP11_REMOTE_LOW] |= l;\n" ">> }\n" - ">> if (lm90_read_reg(client, LM90_REG_R_REMOTE_HIGHH, &h) == 0) {\n" + ">> if (lm90_read_reg(client, LM90_REG_R_REMOTE_HIGHH, &h) = 0) {\n" ">> - data->temp11[2] = h << 8;\n" ">> + data->temp11[TEMP11_REMOTE_HIGH] = h << 8;\n" ">> if ((data->flags & LM90_HAVE_REM_LIMIT_EXT)\n" ">> && lm90_read_reg(client, LM90_REG_R_REMOTE_HIGHL,\n" - ">> &l) == 0)\n" + ">> &l) = 0)\n" ">> - data->temp11[2] |= l;\n" ">> + data->temp11[TEMP11_REMOTE_HIGH] |= l;\n" ">> }\n" ">>\n" ">> if (data->flags & LM90_HAVE_OFFSET) {\n" ">> @@ -529,13 +570,14 @@ static struct lm90_data *lm90_update_device(struct device *dev)\n" - ">> &h) == 0\n" + ">> &h) = 0\n" ">> && lm90_read_reg(client, LM90_REG_R_REMOTE_OFFSL,\n" - ">> &l) == 0)\n" + ">> &l) = 0)\n" ">> - data->temp11[3] = (h << 8) | l;\n" - ">> + data->temp11[TEMP11_REMOTE_OFFSET] =\n" - ">> + (h << 8) | l;\n" + ">> + data->temp11[TEMP11_REMOTE_OFFSET] >> + (h << 8) | l;\n" ">> }\n" ">> if (data->flags & LM90_HAVE_EMERGENCY) {\n" ">> lm90_read_reg(client, MAX6659_REG_R_LOCAL_EMERG,\n" @@ -251,7 +250,7 @@ ">> lm90_read_reg(client, LM90_REG_R_STATUS, &alarms);\n" ">> data->alarms = alarms; /* save as 16 bit value */\n" ">> @@ -543,15 +585,16 @@ static struct lm90_data *lm90_update_device(struct device *dev)\n" - ">> if (data->kind == max6696) {\n" + ">> if (data->kind = max6696) {\n" ">> lm90_select_remote_channel(client, data, 1);\n" ">> lm90_read_reg(client, LM90_REG_R_REMOTE_CRIT,\n" ">> - &data->temp8[6]);\n" @@ -296,14 +295,14 @@ ">> @@ -919,11 +962,12 @@ static ssize_t set_temphyst(struct device *dev, struct device_attribute *dummy,\n" ">>\n" ">> mutex_lock(&data->update_lock);\n" - ">> if (data->kind == adt7461)\n" + ">> if (data->kind = adt7461)\n" ">> - temp = temp_from_u8_adt7461(data, data->temp8[2]);\n" ">> + temp = temp_from_u8_adt7461(data,\n" ">> + data->temp8[TEMP8_LOCAL_CRIT]);\n" "> \n" "> Please align on opening parenthesis.\n" "> \n" - ">> else if (data->kind == max6646)\n" + ">> else if (data->kind = max6646)\n" ">> - temp = temp_from_u8(data->temp8[2]);\n" ">> + temp = temp_from_u8(data->temp8[TEMP8_LOCAL_CRIT]);\n" ">> else\n" @@ -421,6 +420,12 @@ "> \n" "> --\n" "> Jean Delvare\n" - > + "> \n" + "\n" + "\n" + "_______________________________________________\n" + "lm-sensors mailing list\n" + "lm-sensors@lm-sensors.org\n" + http://lists.lm-sensors.org/mailman/listinfo/lm-sensors -536473b60b8c2bffa71e0c9f8979bcf351b00be9ab0551a33702fea39dc78d7a +de891fa42f09ba45661b66781ee299a59aeee78124022f51825e74a10ec68b70
diff --git a/a/1.txt b/N2/1.txt index 45abf92..759b941 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -13,7 +13,7 @@ On 07/27/2013 11:38 PM, Jean Delvare wrote: > Let me review it nevertheless: > >> ->> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> +>> Signed-off-by: Wei Ni <wni@nvidia.com> >> --- >> drivers/hwmon/lm90.c | 179 ++++++++++++++++++++++++++++++++------------------ >> 1 file changed, 114 insertions(+), 65 deletions(-) diff --git a/a/content_digest b/N2/content_digest index 68d63e6..ae554e9 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,16 +1,15 @@ "ref\01373615287-18502-1-git-send-email-wni@nvidia.com\0" "ref\01373615287-18502-5-git-send-email-wni@nvidia.com\0" "ref\020130727173830.14cb5b21@endymion.delvare\0" - "ref\020130727173830.14cb5b21-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org\0" - "From\0Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\0" + "From\0Wei Ni <wni@nvidia.com>\0" "Subject\0Re: [PATCH v3 4/4] hwmon: (lm90) use enums for the indexes of temp8 and temp11\0" "Date\0Mon, 29 Jul 2013 19:15:12 +0800\0" - "To\0Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>\0" - "Cc\0linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>" - thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> - lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org <lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org> - linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> - " linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>\0" + "To\0Jean Delvare <khali@linux-fr.org>\0" + "Cc\0linux@roeck-us.net <linux@roeck-us.net>" + thierry.reding@gmail.com <thierry.reding@gmail.com> + lm-sensors@lm-sensors.org <lm-sensors@lm-sensors.org> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + " linux-tegra@vger.kernel.org <linux-tegra@vger.kernel.org>\0" "\00:1\0" "b\0" "On 07/27/2013 11:38 PM, Jean Delvare wrote:\n" @@ -28,7 +27,7 @@ "> Let me review it nevertheless:\n" "> \n" ">>\n" - ">> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\n" + ">> Signed-off-by: Wei Ni <wni@nvidia.com>\n" ">> ---\n" ">> drivers/hwmon/lm90.c | 179 ++++++++++++++++++++++++++++++++------------------\n" ">> 1 file changed, 114 insertions(+), 65 deletions(-)\n" @@ -423,4 +422,4 @@ "> Jean Delvare\n" > -536473b60b8c2bffa71e0c9f8979bcf351b00be9ab0551a33702fea39dc78d7a +12195f98d9d889cf15a425c91d8b6246838c8459f2f53b8ef51ecbbc365c3339
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.