From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45568)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1V3m44-0005Hq-G6
	for qemu-devel@nongnu.org; Mon, 29 Jul 2013 07:56:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1V3m3z-00036P-Ml
	for qemu-devel@nongnu.org; Mon, 29 Jul 2013 07:56:36 -0400
Received: from p15195424.pureserver.info ([82.165.34.74]:56030)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1V3m3z-00036F-HE
	for qemu-devel@nongnu.org; Mon, 29 Jul 2013 07:56:31 -0400
Message-ID: <51F65849.4030107@ilande.co.uk>
Date: Mon, 29 Jul 2013 12:55:53 +0100
From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
MIME-Version: 1.0
References: <1374889807-21069-1-git-send-email-afaerber@suse.de>
In-Reply-To: <1374889807-21069-1-git-send-email-afaerber@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH qom-next for-1.6 v2] fdc: Fix inheritence
	for SUNW, fdtwo
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: blauwirbel@gmail.com, Hu Tao <hutao@cn.fujitsu.com>, Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>

On 27/07/13 02:50, Andreas Färber wrote:

> Since commit dd3be7420774f7dc8f37a96ca24d07f0b6f31b3b SUNW,fdtwo's
> initfn (realizefn since 940194c2369e50d91d1abf6f36d43853eea5e539)
> was using SYSBUS_FDC() cast. This uses type sysbus-fdc rather than
> SUNW,fdtwo.
>
> Fix this by letting SUNW,fdtwo and sysbus-fdc both inherit from an
> abstract type base-sysbus-fdc.
>
> This allows to consolidate realizefns by using instance_init functions.
> Clean up variable names and variable order while at it.
>
> Reported-by: Mark Cave-Ayland<mark.cave-ayland@ilande.co.uk>
> Cc: Hu Tao<hutao@cn.fujitsu.com>
> Signed-off-by: Andreas Färber<afaerber@suse.de>

Hi Andreas,

I can confirm that this fixes SPARC32 for me - thanks!

Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


ATB,

Mark.