From: "Andreas Färber" <afaerber@suse.de>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: blauwirbel@gmail.com, Hu Tao <hutao@cn.fujitsu.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH qom-next for-1.6 v2] fdc: Fix inheritence for SUNW, fdtwo
Date: Mon, 29 Jul 2013 14:15:32 +0200 [thread overview]
Message-ID: <51F65CE4.1040501@suse.de> (raw)
In-Reply-To: <51F65849.4030107@ilande.co.uk>
Am 29.07.2013 13:55, schrieb Mark Cave-Ayland:
> On 27/07/13 02:50, Andreas Färber wrote:
>
>> Since commit dd3be7420774f7dc8f37a96ca24d07f0b6f31b3b SUNW,fdtwo's
>> initfn (realizefn since 940194c2369e50d91d1abf6f36d43853eea5e539)
>> was using SYSBUS_FDC() cast. This uses type sysbus-fdc rather than
>> SUNW,fdtwo.
>>
>> Fix this by letting SUNW,fdtwo and sysbus-fdc both inherit from an
>> abstract type base-sysbus-fdc.
>>
>> This allows to consolidate realizefns by using instance_init functions.
>> Clean up variable names and variable order while at it.
>>
>> Reported-by: Mark Cave-Ayland<mark.cave-ayland@ilande.co.uk>
>> Cc: Hu Tao<hutao@cn.fujitsu.com>
>> Signed-off-by: Andreas Färber<afaerber@suse.de>
>
> Hi Andreas,
>
> I can confirm that this fixes SPARC32 for me - thanks!
>
> Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Thanks. Can you give my latest qom-devices branch a whirl, too?
I started adding trivial qtests for machines, but only covering the
default machines without -fda etc.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
prev parent reply other threads:[~2013-07-29 12:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-27 1:50 [Qemu-devel] [PATCH qom-next for-1.6 v2] fdc: Fix inheritence for SUNW, fdtwo Andreas Färber
2013-07-27 2:17 ` Andreas Färber
2013-07-29 11:55 ` Mark Cave-Ayland
2013-07-29 12:15 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F65CE4.1040501@suse.de \
--to=afaerber@suse.de \
--cc=blauwirbel@gmail.com \
--cc=hutao@cn.fujitsu.com \
--cc=kwolf@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.