From: Paolo Bonzini <pbonzini@redhat.com>
To: liu ping fan <qemulist@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
qemu-devel@nongnu.org, Alex Bligh <alex@alex.org.uk>,
Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [RFC v2 4/5] timer: associate three timerlists with AioContext
Date: Mon, 29 Jul 2013 15:11:57 +0200 [thread overview]
Message-ID: <51F66A1D.2020409@redhat.com> (raw)
In-Reply-To: <CAJnKYQn7NhP-i3oNNE3e14MgYMS2HmR3OU-th3XYWFxRMyVZHw@mail.gmail.com>
Il 29/07/2013 10:20, liu ping fan ha scritto:
>> > Another issue is that deadline computation is not using the AioContext's
>> > timer lists.
>> >
> Sorry, can not catch the meaning. When AioContext has its own timer
> lists, it will have its own deadline(for ppoll timeout). So the
> computation should be based on AioContext's timer lists, right?
Associating the main loop's timer lists to other AioContexts is really
really wrong... It is _already_ wrong to run timers in the main
AioContext's aio_poll (because timers may not be ready to run from an
arbitrary aio_poll), it is even worse to run them in other threads
without taking the BQL.
What exactly is the purpose of this series?
Paolo
next prev parent reply other threads:[~2013-07-29 13:12 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 3:16 [Qemu-devel] [RFC v2 0/5] arm AioContext with its own timer stuff Liu Ping Fan
2013-07-29 3:16 ` [Qemu-devel] [RFC v2 1/5] timer: protect timers_state with lock Liu Ping Fan
2013-07-29 6:26 ` Paolo Bonzini
2013-07-29 8:01 ` liu ping fan
2013-07-29 3:16 ` [Qemu-devel] [RFC v2 2/5] timer: pick out timer list info from QemuClock Liu Ping Fan
2013-07-29 3:16 ` [Qemu-devel] [RFC v2 3/5] timer: make qemu_clock_enable sync between disable and timer's cb Liu Ping Fan
2013-07-29 6:30 ` Paolo Bonzini
2013-07-29 8:10 ` liu ping fan
2013-07-29 11:21 ` Paolo Bonzini
2013-07-30 2:42 ` liu ping fan
2013-07-30 9:17 ` Paolo Bonzini
2013-07-30 9:51 ` Alex Bligh
2013-07-30 10:12 ` Paolo Bonzini
2013-08-01 5:54 ` liu ping fan
2013-08-01 8:57 ` Paolo Bonzini
2013-08-01 9:35 ` Alex Bligh
2013-08-01 12:19 ` Paolo Bonzini
2013-08-01 13:28 ` Alex Bligh
2013-08-01 13:51 ` Paolo Bonzini
2013-08-01 14:20 ` Alex Bligh
2013-08-01 14:28 ` Paolo Bonzini
2013-08-02 3:31 ` liu ping fan
2013-08-02 10:01 ` Paolo Bonzini
2013-08-02 3:33 ` liu ping fan
2013-08-02 14:43 ` Stefan Hajnoczi
2013-08-05 2:13 ` liu ping fan
2013-07-29 3:16 ` [Qemu-devel] [RFC v2 4/5] timer: associate three timerlists with AioContext Liu Ping Fan
2013-07-29 6:32 ` Paolo Bonzini
2013-07-29 8:20 ` liu ping fan
2013-07-29 13:11 ` Paolo Bonzini [this message]
2013-07-30 2:35 ` liu ping fan
2013-07-29 3:16 ` [Qemu-devel] [RFC v2 5/5] timer: run timers on aio_poll Liu Ping Fan
2013-07-29 9:22 ` [Qemu-devel] [RFC v2 0/5] arm AioContext with its own timer stuff Stefan Hajnoczi
2013-07-29 10:23 ` Alex Bligh
2013-07-29 13:36 ` Stefan Hajnoczi
2013-07-29 13:56 ` Alex Bligh
2013-07-30 3:35 ` liu ping fan
2013-07-29 10:18 ` Alex Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F66A1D.2020409@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex@alex.org.uk \
--cc=anthony@codemonkey.ws \
--cc=jan.kiszka@siemens.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemulist@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.