diff for duplicates of <51F68F73.9060603@samsung.com> diff --git a/a/1.txt b/N1/1.txt index 4ce28a5..f52a68c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -119,7 +119,7 @@ Bad Things happen. ;) Don't you need something like - if (phy->init_data = NULL) + if (phy->init_data == NULL) return ERR_PTR(-EINVAL); to ensure there is no attempt to dereference NULL platform data ? @@ -153,7 +153,7 @@ to ensure there is no attempt to dereference NULL platform data ? > + return ret; > + > + mutex_lock(&phy->mutex); -> + if (phy->init_count++ = 0 && phy->ops->init) { +> + if (phy->init_count++ == 0 && phy->ops->init) { > + ret = phy->ops->init(phy); > + if (ret < 0) { > + dev_err(&phy->dev, "phy init failed --> %d\n", ret); @@ -180,7 +180,7 @@ Is this 'goto' and similar ones below really needed ? > + return ret; > + > + mutex_lock(&phy->mutex); -> + if (--phy->init_count = 0 && phy->ops->exit) { +> + if (--phy->init_count == 0 && phy->ops->exit) { > + ret = phy->ops->exit(phy); > + if (ret < 0) { > + dev_err(&phy->dev, "phy exit failed --> %d\n", ret); @@ -204,7 +204,7 @@ Is this 'goto' and similar ones below really needed ? > + return ret; > + > + mutex_lock(&phy->mutex); -> + if (phy->power_count++ = 0 && phy->ops->power_on) { +> + if (phy->power_count++ == 0 && phy->ops->power_on) { > + ret = phy->ops->power_on(phy); > + if (ret < 0) { > + dev_err(&phy->dev, "phy poweron failed --> %d\n", ret); @@ -224,7 +224,7 @@ Is this 'goto' and similar ones below really needed ? > + int ret = -ENOTSUPP; > + > + mutex_lock(&phy->mutex); -> + if (--phy->power_count = 0 && phy->ops->power_off) { +> + if (--phy->power_count == 0 && phy->ops->power_off) { > + ret = phy->ops->power_off(phy); > + if (ret < 0) { > + dev_err(&phy->dev, "phy poweroff failed --> %d\n", ret); diff --git a/a/content_digest b/N1/content_digest index 2d04d21..17d25c1 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,8 +2,35 @@ "ref\01374842963-13545-2-git-send-email-kishon@ti.com\0" "From\0Sylwester Nawrocki <s.nawrocki@samsung.com>\0" "Subject\0Re: [RESEND PATCH v10 1/8] drivers: phy: add generic PHY framework\0" - "Date\0Mon, 29 Jul 2013 15:51:15 +0000\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "Date\0Mon, 29 Jul 2013 17:51:15 +0200\0" + "To\0Kishon Vijay Abraham I <kishon@ti.com>\0" + "Cc\0gregkh@linuxfoundation.org" + kyungmin.park@samsung.com + balbi@ti.com + jg1.han@samsung.com + kgene.kim@samsung.com + stern@rowland.harvard.edu + broonie@kernel.org + tomasz.figa@gmail.com + arnd@arndb.de + devicetree@vger.kernel.org + linux-fbdev@vger.kernel.org + linux-samsung-soc@vger.kernel.org + swarren@nvidia.com + balajitk@ti.com + linux-doc@vger.kernel.org + tony@atomide.com + Tomasz Figa <t.figa@samsung.com> + linux-usb@vger.kernel.org + nsekhar@ti.com + linux-kernel@vger.kernel.org + grant.likely@linaro.org + linux@arm.linux.org.uk + akpm@linux-foundation.org + linux-omap@vger.kernel.org + george.cherian@ti.com + linux-arm-kernel@lists.infradead.org + " linux-media@vger.kernel.org\0" "\00:1\0" "b\0" "On 07/26/2013 02:49 PM, Kishon Vijay Abraham I wrote:\n" @@ -127,7 +154,7 @@ "\t\n" "Don't you need something like\n" "\n" - "\tif (phy->init_data = NULL)\t\n" + "\tif (phy->init_data == NULL)\t\n" "\t\treturn ERR_PTR(-EINVAL);\n" "\n" "to ensure there is no attempt to dereference NULL platform data ?\n" @@ -161,7 +188,7 @@ "> +\t\treturn ret;\n" "> +\n" "> +\tmutex_lock(&phy->mutex);\n" - "> +\tif (phy->init_count++ = 0 && phy->ops->init) {\n" + "> +\tif (phy->init_count++ == 0 && phy->ops->init) {\n" "> +\t\tret = phy->ops->init(phy);\n" "> +\t\tif (ret < 0) {\n" "> +\t\t\tdev_err(&phy->dev, \"phy init failed --> %d\\n\", ret);\n" @@ -188,7 +215,7 @@ "> +\t\treturn ret;\n" "> +\n" "> +\tmutex_lock(&phy->mutex);\n" - "> +\tif (--phy->init_count = 0 && phy->ops->exit) {\n" + "> +\tif (--phy->init_count == 0 && phy->ops->exit) {\n" "> +\t\tret = phy->ops->exit(phy);\n" "> +\t\tif (ret < 0) {\n" "> +\t\t\tdev_err(&phy->dev, \"phy exit failed --> %d\\n\", ret);\n" @@ -212,7 +239,7 @@ "> +\t\treturn ret;\n" "> +\n" "> +\tmutex_lock(&phy->mutex);\n" - "> +\tif (phy->power_count++ = 0 && phy->ops->power_on) {\n" + "> +\tif (phy->power_count++ == 0 && phy->ops->power_on) {\n" "> +\t\tret = phy->ops->power_on(phy);\n" "> +\t\tif (ret < 0) {\n" "> +\t\t\tdev_err(&phy->dev, \"phy poweron failed --> %d\\n\", ret);\n" @@ -232,7 +259,7 @@ "> +\tint ret = -ENOTSUPP;\n" "> +\n" "> +\tmutex_lock(&phy->mutex);\n" - "> +\tif (--phy->power_count = 0 && phy->ops->power_off) {\n" + "> +\tif (--phy->power_count == 0 && phy->ops->power_off) {\n" "> +\t\tret = phy->ops->power_off(phy);\n" "> +\t\tif (ret < 0) {\n" "> +\t\t\tdev_err(&phy->dev, \"phy poweroff failed --> %d\\n\", ret);\n" @@ -252,4 +279,4 @@ "Thanks,\n" Sylwester -4a78b5ba79a50f4c6bde23d1c3d39c6922ceff0492d31529ca547b3fc9251a25 +96f34a4a899f84a36f672ea2da992530bebb3ddb20e9168e93f1224cb5054abb
diff --git a/a/1.txt b/N2/1.txt index 4ce28a5..f52a68c 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -119,7 +119,7 @@ Bad Things happen. ;) Don't you need something like - if (phy->init_data = NULL) + if (phy->init_data == NULL) return ERR_PTR(-EINVAL); to ensure there is no attempt to dereference NULL platform data ? @@ -153,7 +153,7 @@ to ensure there is no attempt to dereference NULL platform data ? > + return ret; > + > + mutex_lock(&phy->mutex); -> + if (phy->init_count++ = 0 && phy->ops->init) { +> + if (phy->init_count++ == 0 && phy->ops->init) { > + ret = phy->ops->init(phy); > + if (ret < 0) { > + dev_err(&phy->dev, "phy init failed --> %d\n", ret); @@ -180,7 +180,7 @@ Is this 'goto' and similar ones below really needed ? > + return ret; > + > + mutex_lock(&phy->mutex); -> + if (--phy->init_count = 0 && phy->ops->exit) { +> + if (--phy->init_count == 0 && phy->ops->exit) { > + ret = phy->ops->exit(phy); > + if (ret < 0) { > + dev_err(&phy->dev, "phy exit failed --> %d\n", ret); @@ -204,7 +204,7 @@ Is this 'goto' and similar ones below really needed ? > + return ret; > + > + mutex_lock(&phy->mutex); -> + if (phy->power_count++ = 0 && phy->ops->power_on) { +> + if (phy->power_count++ == 0 && phy->ops->power_on) { > + ret = phy->ops->power_on(phy); > + if (ret < 0) { > + dev_err(&phy->dev, "phy poweron failed --> %d\n", ret); @@ -224,7 +224,7 @@ Is this 'goto' and similar ones below really needed ? > + int ret = -ENOTSUPP; > + > + mutex_lock(&phy->mutex); -> + if (--phy->power_count = 0 && phy->ops->power_off) { +> + if (--phy->power_count == 0 && phy->ops->power_off) { > + ret = phy->ops->power_off(phy); > + if (ret < 0) { > + dev_err(&phy->dev, "phy poweroff failed --> %d\n", ret); diff --git a/a/content_digest b/N2/content_digest index 2d04d21..6d37093 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,8 +1,8 @@ "ref\01374842963-13545-1-git-send-email-kishon@ti.com\0" "ref\01374842963-13545-2-git-send-email-kishon@ti.com\0" - "From\0Sylwester Nawrocki <s.nawrocki@samsung.com>\0" - "Subject\0Re: [RESEND PATCH v10 1/8] drivers: phy: add generic PHY framework\0" - "Date\0Mon, 29 Jul 2013 15:51:15 +0000\0" + "From\0s.nawrocki@samsung.com (Sylwester Nawrocki)\0" + "Subject\0[RESEND PATCH v10 1/8] drivers: phy: add generic PHY framework\0" + "Date\0Mon, 29 Jul 2013 17:51:15 +0200\0" "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" @@ -127,7 +127,7 @@ "\t\n" "Don't you need something like\n" "\n" - "\tif (phy->init_data = NULL)\t\n" + "\tif (phy->init_data == NULL)\t\n" "\t\treturn ERR_PTR(-EINVAL);\n" "\n" "to ensure there is no attempt to dereference NULL platform data ?\n" @@ -161,7 +161,7 @@ "> +\t\treturn ret;\n" "> +\n" "> +\tmutex_lock(&phy->mutex);\n" - "> +\tif (phy->init_count++ = 0 && phy->ops->init) {\n" + "> +\tif (phy->init_count++ == 0 && phy->ops->init) {\n" "> +\t\tret = phy->ops->init(phy);\n" "> +\t\tif (ret < 0) {\n" "> +\t\t\tdev_err(&phy->dev, \"phy init failed --> %d\\n\", ret);\n" @@ -188,7 +188,7 @@ "> +\t\treturn ret;\n" "> +\n" "> +\tmutex_lock(&phy->mutex);\n" - "> +\tif (--phy->init_count = 0 && phy->ops->exit) {\n" + "> +\tif (--phy->init_count == 0 && phy->ops->exit) {\n" "> +\t\tret = phy->ops->exit(phy);\n" "> +\t\tif (ret < 0) {\n" "> +\t\t\tdev_err(&phy->dev, \"phy exit failed --> %d\\n\", ret);\n" @@ -212,7 +212,7 @@ "> +\t\treturn ret;\n" "> +\n" "> +\tmutex_lock(&phy->mutex);\n" - "> +\tif (phy->power_count++ = 0 && phy->ops->power_on) {\n" + "> +\tif (phy->power_count++ == 0 && phy->ops->power_on) {\n" "> +\t\tret = phy->ops->power_on(phy);\n" "> +\t\tif (ret < 0) {\n" "> +\t\t\tdev_err(&phy->dev, \"phy poweron failed --> %d\\n\", ret);\n" @@ -232,7 +232,7 @@ "> +\tint ret = -ENOTSUPP;\n" "> +\n" "> +\tmutex_lock(&phy->mutex);\n" - "> +\tif (--phy->power_count = 0 && phy->ops->power_off) {\n" + "> +\tif (--phy->power_count == 0 && phy->ops->power_off) {\n" "> +\t\tret = phy->ops->power_off(phy);\n" "> +\t\tif (ret < 0) {\n" "> +\t\t\tdev_err(&phy->dev, \"phy poweroff failed --> %d\\n\", ret);\n" @@ -252,4 +252,4 @@ "Thanks,\n" Sylwester -4a78b5ba79a50f4c6bde23d1c3d39c6922ceff0492d31529ca547b3fc9251a25 +9fd22cb8dd0464f9f3be4aedd07888480b41b3e1de1b1913c6092d5f98195ddd
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.