From: b.brezillon@overkiz.com (boris brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: at91: choose appropriate handler for level interrupts
Date: Mon, 29 Jul 2013 17:52:16 +0200 [thread overview]
Message-ID: <51F68FB0.4090507@overkiz.com> (raw)
In-Reply-To: <CACRpkdaGdgLeYrahv0qAJJjL3S2aiZeVwRVUtNcDqQgL3_mQkA@mail.gmail.com>
On 29/07/2013 17:42, Linus Walleij wrote:
> On Sat, Jul 20, 2013 at 4:51 PM, Boris BREZILLON
> <b.brezillon@overkiz.com> wrote:
>
>> The current implementation handle both edge and level interrupts with the
>> 'handle_simple_irq' handler.
>>
>> Level interrupts are active as long as the pin stays at the configured
>> level (low or high). In this case we have to use 'handle_level_irq' which
>> mask the interrupt until the handle has treated it.
>>
>> Signed-off-by: Boris BREZILLON <b.brezillon@overkiz.com>
> Nicolas/Jean-Christophe: any opinion on this patch?
>
> I am tempted to just apply it and see if you react to it :-)
Hello,
Just for clarification, without this patch the kernel hangs if you request a
threaded irq on level state (low or high).
This was tested on sama5ek board.
Best Regards,
Boris
>
> Yours,
> Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: boris brezillon <b.brezillon@overkiz.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Ludovic Desroches <ludovic.desroches@atmel.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: at91: choose appropriate handler for level interrupts
Date: Mon, 29 Jul 2013 17:52:16 +0200 [thread overview]
Message-ID: <51F68FB0.4090507@overkiz.com> (raw)
In-Reply-To: <CACRpkdaGdgLeYrahv0qAJJjL3S2aiZeVwRVUtNcDqQgL3_mQkA@mail.gmail.com>
On 29/07/2013 17:42, Linus Walleij wrote:
> On Sat, Jul 20, 2013 at 4:51 PM, Boris BREZILLON
> <b.brezillon@overkiz.com> wrote:
>
>> The current implementation handle both edge and level interrupts with the
>> 'handle_simple_irq' handler.
>>
>> Level interrupts are active as long as the pin stays at the configured
>> level (low or high). In this case we have to use 'handle_level_irq' which
>> mask the interrupt until the handle has treated it.
>>
>> Signed-off-by: Boris BREZILLON <b.brezillon@overkiz.com>
> Nicolas/Jean-Christophe: any opinion on this patch?
>
> I am tempted to just apply it and see if you react to it :-)
Hello,
Just for clarification, without this patch the kernel hangs if you request a
threaded irq on level state (low or high).
This was tested on sama5ek board.
Best Regards,
Boris
>
> Yours,
> Linus Walleij
next prev parent reply other threads:[~2013-07-29 15:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-20 14:51 [PATCH] pinctrl: at91: choose appropriate handler for level interrupts Boris BREZILLON
2013-07-20 14:51 ` Boris BREZILLON
2013-07-29 15:42 ` Linus Walleij
2013-07-29 15:42 ` Linus Walleij
2013-07-29 15:52 ` boris brezillon [this message]
2013-07-29 15:52 ` boris brezillon
2013-08-12 15:18 ` Nicolas Ferre
2013-08-12 15:18 ` Nicolas Ferre
2013-08-01 11:04 ` Alexandre Belloni
2013-08-01 11:04 ` Alexandre Belloni
2013-08-01 11:07 ` boris brezillon
2013-08-01 11:07 ` boris brezillon
2013-08-07 18:59 ` Linus Walleij
2013-08-07 18:59 ` Linus Walleij
2013-08-08 4:10 ` boris brezillon
2013-08-08 4:10 ` boris brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F68FB0.4090507@overkiz.com \
--to=b.brezillon@overkiz.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.