From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Stefano.Stabellini@eu.citrix.com, patches@linaro.org,
xen-devel@lists.xen.org
Subject: Re: [PATCH 6/8] exynos4210: rename UTRSTAT_TX_EMPTY in UTRSTAT_TXFE
Date: Mon, 29 Jul 2013 17:46:06 +0100 [thread overview]
Message-ID: <51F69C4E.9070908@linaro.org> (raw)
In-Reply-To: <1375115232.11701.30.camel@kazak.uk.xensource.com>
On 07/29/2013 05:27 PM, Ian Campbell wrote:
> Why the rename?
To avoid confusion with UTRSTAT_TXE (introduce on the next patch). The
real name of this bit is UTRSTAT_TXFE.
> Also no S-o-b..
Oh right. Will be add on the next patch series.
> On Thu, 2013-07-25 at 17:59 +0100, Julien Grall wrote:
>> ---
>> xen/arch/arm/arm32/debug-exynos4210.inc | 2 +-
>> xen/include/asm-arm/exynos4210-uart.h | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/xen/arch/arm/arm32/debug-exynos4210.inc b/xen/arch/arm/arm32/debug-exynos4210.inc
>> index d746c35..5a5ff68 100644
>> --- a/xen/arch/arm/arm32/debug-exynos4210.inc
>> +++ b/xen/arch/arm/arm32/debug-exynos4210.inc
>> @@ -56,7 +56,7 @@
>> .macro early_uart_ready rb rc
>> 1:
>> ldr \rc, [\rb, #UTRSTAT] /* <- UTRSTAT (Flag register) */
>> - tst \rc, #UTRSTAT_TX_EMPTY /* Check BUSY bit */
>> + tst \rc, #UTRSTAT_TXFE /* Check BUSY bit */
>
> Pls keep the comment aligned.
>
>> beq 1b /* Wait for the UART to be ready */
>> .endm
>>
>> diff --git a/xen/include/asm-arm/exynos4210-uart.h b/xen/include/asm-arm/exynos4210-uart.h
>> index 330e1c0..bd9a4be 100644
>> --- a/xen/include/asm-arm/exynos4210-uart.h
>> +++ b/xen/include/asm-arm/exynos4210-uart.h
>> @@ -87,7 +87,7 @@
>> #define UFSTAT_RX_COUNT_MASK (0xff << UFSTAT_RX_COUNT_SHIFT)
>>
>> /* UTRSTAT */
>> -#define UTRSTAT_TX_EMPTY (1 << 1)
>> +#define UTRSTAT_TXFE (1 << 1)
>>
>> /* URHX */
>> #define URXH_DATA_MASK (0xff)
>
>
next prev parent reply other threads:[~2013-07-29 16:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 16:59 [PATCH 0/8] Emulate virtual UART for DOM0 and some UART clean up Julien Grall
2013-07-25 16:59 ` [PATCH 2/8] pl011: Move registers' definition in a separate file Julien Grall
2013-07-29 16:24 ` Ian Campbell
2013-07-29 16:35 ` Julien Grall
2013-07-30 10:00 ` Ian Campbell
2013-07-30 10:19 ` Julien Grall
2013-07-25 16:59 ` [PATCH 3/8] xen/arm: Use define instead of hardcoded value in debug-pl011 Julien Grall
2013-07-25 16:59 ` [PATCH 4/8] xen/arm: New callback in uart_driver to retrieve serial information Julien Grall
2013-07-29 16:29 ` Ian Campbell
2013-07-29 16:36 ` Julien Grall
2013-07-25 16:59 ` [PATCH 5/8] xen/arm: Implement a virtual UART Julien Grall
2013-07-29 16:26 ` Ian Campbell
2013-07-29 16:40 ` Julien Grall
2013-07-30 10:07 ` Ian Campbell
2013-07-25 16:59 ` [PATCH 6/8] exynos4210: rename UTRSTAT_TX_EMPTY in UTRSTAT_TXFE Julien Grall
2013-07-29 16:27 ` Ian Campbell
2013-07-29 16:46 ` Julien Grall [this message]
2013-07-25 16:59 ` [PATCH 7/8] exynos4210: Implement serial_info callback Julien Grall
2013-07-25 16:59 ` [PATCH 8/8] pl011: " Julien Grall
[not found] ` <1374771574-7848-2-git-send-email-julien.grall@linaro.org>
2013-07-29 16:23 ` [PATCH 1/8] pl011: Use ioreadl/iowritel Ian Campbell
2013-07-29 16:30 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F69C4E.9070908@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=patches@linaro.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.