From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Vadim A. Misbakh-Soloviov" Subject: Re: [PATCH] XEN-4.3.0 tools-bugs [FLASK] [SEABIOS] Date: Mon, 29 Jul 2013 21:11:29 +0400 Message-ID: <51F6A241.8090504@mva.name> References: <51F3D782.2030307@mva.name> <1375091284.14896.40.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7306108839137229580==" Return-path: In-Reply-To: <1375091284.14896.40.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Xen Developers List , Daniel De Graaf List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============7306108839137229580== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="VAa17nP4Bprb5usjmPk5neBati0AhIto0" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --VAa17nP4Bprb5usjmPk5neBati0AhIto0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable 29.07.2013 13:48, Ian Campbell =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > On Sat, 2013-07-27 at 18:21 +0400, Vadim A. Misbakh-Soloviov wrote: >> Hi! I've found few bugs in Xen-4.3.0: >=20 > Thanks. For future reference it would be really useful to send these as= > individual mails. >=20 > We also discourage cross-posting. I've moved the thread to -devel. >=20 >> FLASK part: >> >> 1) first of all, I'm discouraged, that flask policy builds without >> FLASK_ENABLE=3Dy. I guess, it is because I've SELinux in dom0, but, >> anyway, since I've not enabled FLASK myself, I suggest that it will no= t >> be build. >=20 > Building the policy seems harmless even if FLASK is not enabled? If > nothing else it gets us better build testing coverage To be honest, not that it is harmless to build policy. Just I think, it is unneded, if FLASK is disabled. And, anyway, main issue is that it installs as "/boot" >> 2) Moreover, that flask policy builds despite of I don't enabled flask= , >> somewhy it installs as "/boot" due to >>> POLICY_LOADPATH =3D $(DESTDIR)/boot >> (I checked it by changing value to boot3, and that policy was renamed = too) >> >> I guess, nobody get that issue due to less of people build xen/xen-too= ls >> in sandbox, while Gentoo, for example, have both build and install in >> sandboxed environment (so, there is no system /boot dir), and policy g= et >> "/boot" name. >=20 > Yes, it seems that the install rule should gain an "$(INSTALL_DIR) > $(DESTDIR)$(POLICY_LOADPATH)" at the start. COuld you send such a patch= > please. See http://wiki.xen.org/wiki/Submitting_Xen_Patches for guidanc= e > if you need it. Ok, just sent patches. >=20 >> >> >> bundled SeaBIOS part: >> >> 3) >> >> make -C seabios-dir all >> Working around non-functional -fwhole-program >> make[5]: Entering directory >> `/var/tmp/portage/app-emulation/xen-tools-4.3.0/work/xen-4.3.0/tools/f= irmware/seabios-dir-remote' >> make[6]: warning: jobserver unavailable: using -j1. Add `+' to parent= >> make rule. >> Build default config >> # >> # configuration written to >> /var/tmp/portage/app-emulation/xen-tools-4.3.0/work/xen-4.3.0/tools/fi= rmware/seabios-dir-remote/.config >> # >> make[5]: Leaving directory >> `/var/tmp/portage/app-emulation/xen-tools-4.3.0/work/xen-4.3.0/tools/f= irmware/seabios-dir-remote' >> Working around non-functional -fwhole-program >> Compiling IASL out/acpi-dsdt.hex >> make[6]: warning: jobserver unavailable: using -j1. Add `+' to parent= >> make rule. >> Compiling IASL out/ssdt-proc.hex >> Build Kconfig config file >> >> >> That jobserver issues makes buildsystem continue build process at >> installation phase. >=20 > I'm not sure I understand. Are you saying that this issue means some > stuff doesn't get built at "make build" time but only gets built at > "make install" time? That would be very strange. I'm not sure it would > necessarily be related to this jobserver thing. Yes, I mean that some qemu related part builds at 'make install' time, and I guess, it is due to that jobserver thing. >> 4) if user tries to build xen-tools with UTF-8 locale, >=20 > Which locale specifically? What is your $LANG? >=20 ru_RU.UTF-8, but as mentioned in bug on Gentoo bugzilla, all the same on italian UTF-8 locale. >> he gets: >> >> Version: rel-1.7.1-3-g3a28511-20130727_172824-node1 >> Traceback (most recent call last): >> File "./tools/layoutrom.py", line 630, in >> main() >> File "./tools/layoutrom.py", line 607, in main >> info16 =3D parseObjDump(infile16, '16') >> File "./tools/layoutrom.py", line 538, in parseObjDump >> relocsection =3D sectionmap[sectionname] >> KeyError: '.text.asm.out/../src/smp.c.77' >> >> (there is some more info: https://bugs.gentoo.org/show_bug.cgi?id=3D44= 5986 ) >=20 > This looks like a SeaBIOS issue. Have you checked the upstream SeaBIOS > tree for a fix? Does it counts, that system-wide seabios package (1.7.2.1 and 1.7.2.2 versions), builds and installs fine? > The right way to go about fixing this would probably be > to report upstream, can you do that? (please feel free to CC me and > xen-devel). Sure, I can, but I doubt, it give some result, since system-wide seabois (from code.coreboot.org) installs just fine. > That patch is probably to use LANG=3DC at various points in > the SeaBIOS makefile. Actually, it is already temporary workaround, but I doubt it is good idea to do such things widely, so I think, it needs real fix of issue, instead of hining it by locale change. -- Best regards, mva --VAa17nP4Bprb5usjmPk5neBati0AhIto0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJR9qJCAAoJECZQPTSbOzNL+WgQAMa1n84SFZjg7HLbzQDsAmNd 6a+Y+k2GhEOr+GmBmyt3Q7pp5u4/6cHfLsp18dsifxmNv+bgItvRewGP1Hm8P5Rm WFEX7w8JR79jR+O5cQUDMfOuuqqAwWoA7rHQt4vsI2SWSMfhFaUPH4K3yDFzBaW2 e2K5VKhaNRJyY7Ufe9uBIinEPdxfDwBO7834BVhlaSBxSxHhlEaEiTjOl+KTAGNv IGwgEbwLN+GmDi9lOiMRW6qmMu05bm028eNcMIXJiEZceCZoZ9InOaS5wR300BPx 70ygL3OmCD9RLQW10Wg/73L935eKs9zBF6j78P2yrlkiNfQk2KJ9BkM54sl7bakj wbuP5Dv81J2GzLXaJU2oHVMopoNx4xN7UypLIOZUZq6TXhBA0osJOcjCjCv6PAo6 qMtxGGeg6pK0yV0VQ5zfjebwF32swAxVxrJCjgKArpfnSK04S1huNRbYxVUjkJyR rZMY7u1HoANyoVEWy7nuf/SIe5gVKqkjA//XQEzADN65wH68OqvLaLgai6rBR5hp /+H+z2seE4ePIR6oIDlkqlqFN6CwMmj8v/GiZZ2K+k7lZHljqvV3H8oLnJUX2DEf sGqKXSH2i2H2nI9U5ZnXxVKYAQykY3LBXsLJijWaCm9dRmP902YbJb/no+wKji9Z zTQSEPoU+yUirHzhwbCk =DxK5 -----END PGP SIGNATURE----- --VAa17nP4Bprb5usjmPk5neBati0AhIto0-- --===============7306108839137229580== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============7306108839137229580==--