From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Vadim A. Misbakh-Soloviov" Subject: Re: [PATCH 1/2] Fixed flask policy's install path to avoid installing it as '/boot' file Date: Mon, 29 Jul 2013 21:20:59 +0400 Message-ID: <51F6A47B.8060301@mva.name> References: <1375117309-13808-1-git-send-email-mva@mva.name> <51F6A3FB.3080001@tycho.nsa.gov> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5946644105223359647==" Return-path: In-Reply-To: <51F6A3FB.3080001@tycho.nsa.gov> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Daniel De Graaf Cc: Ian Campbell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============5946644105223359647== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oKnq2uVK0ibnSpH5j1ctXdmE9l8WST7WG" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --oKnq2uVK0ibnSpH5j1ctXdmE9l8WST7WG Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Okay, thanks. So, Can I just ammend commits and resend both patches again? :) 29.07.2013 21:18, Daniel De Graaf =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > On 07/29/2013 01:01 PM, Vadim A. Misbakh-Soloviov wrote: >> From: "Vadim A. Misbakh-Soloviov" >> >> Signed-off-by: Vadim A. Misbakh-Soloviov >> --- >> tools/flask/policy/Makefile | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/tools/flask/policy/Makefile b/tools/flask/policy/Makefile= >> index e666f3e..d917231 100644 >> --- a/tools/flask/policy/Makefile >> +++ b/tools/flask/policy/Makefile >> @@ -103,6 +103,7 @@ POLICY_SECTIONS +=3D $(USERS) $(CONSTRAINTS) >> $(ISID_DEFS) >> all: $(POLICY_FILENAME) >> >> install: $(POLICY_FILENAME) >> + $(INSTALL_DIR) $(DESTDIR)$(POLICY_LOADPATH) >> $(INSTALL_DATA) $^ $(POLICY_LOADPATH) >> >> $(POLICY_FILENAME): policy.conf >> >=20 > POLICY_LOADPATH is defined as $(DESTDIR)/boot, so this expands to: > $(INSTALL_DIR) $(DESTDIR)$(DESTDIR)/boot >=20 > I believe the correct fix is to instead add: > $(INSTALL_DIR) $(POLICY_LOADPATH) >=20 > With that change, this patch is >=20 > Acked-by: Daniel De Graaf >=20 > Patch 2/2 looks correct as-is or with Andrew's cleanup. >=20 --oKnq2uVK0ibnSpH5j1ctXdmE9l8WST7WG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJR9qR7AAoJECZQPTSbOzNLMf4P/iVzaby9pCV7Dg4L5omMcIxI DNUwEx9motuJUaKjHpfawtAeMcRtWHxw/T02x7DCG8w5ATS+1W8R/9QbIXSJP7/X NgRNuU5/SGyGNOQwA4u1fsv3IdFoM5t130ZykhLcKAUqG1EbjoSiFD09tmSaRERE DKN5enRAXipbVl4zb5Cye85CmbCGegrvqn/k/6B3VQhK2a3L8m+FB5gGJxYUCelL 9emgpz38pcCsmZskR5y1U7lNJtq7oHlN5e9O1UyGX0GRbeLoeyyhtSdEOy2uggmA uR3jE+bxzaqcJ5/a4+T+vHavnS4nJB+RszfE6U7UwpWP/JLq2Wb52pOBEW8HcX/I ZaIxFVtfGTKMlv6rQ92UOjHS4er7QRDPGDHLs/T6oxaWqprrmSJcFFOSWngpmzx5 LUedSuG+zItmOw1YVoE6UQ/UVOQ73Vmr+V7CmM09WEfWywFIEpuZBSTZhDp8Xhec XPae+tUs7pj7JEYUeThyu5+1XGU9AbPMYLJdx/Prt3xTKWYD6tF8KNjbjKFS2NGf iuDxdG63Wh9T1VO2YyUzz0y4rCYoef7zmTHKhk+wy0tjGfNInWSCOImC0TnexzSE 3Rrd+Vz7Pi3MifBP0LlnfZKvE7QKkyIsudUTvDdh/8npLYrfygB1Zv/SmLILOJjH 6TO0Oi6i9o127rLXEAku =J3n/ -----END PGP SIGNATURE----- --oKnq2uVK0ibnSpH5j1ctXdmE9l8WST7WG-- --===============5946644105223359647== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============5946644105223359647==--