Re: [PATCH 4/9] scsi: ufs: Add runtime PM support for UFS host controller driver

[Sujit Reddy Thumma <sthumma@codeaurora.org>]

On 7/28/2013 10:40 PM, Santosh Y wrote:
> +
>   /**
>    * ufshcd_pltfrm_probe - probe routine of the driver
>    * @pdev: pointer to Platform device handle
> @@ -122,14 +157,20 @@ static int ufshcd_pltfrm_probe(struct platform_device *pdev)
>   		goto out;
>   	}
>
> +	pm_runtime_set_active(&pdev->dev);
> +	pm_runtime_enable(&pdev->dev);
> +
>   	err = ufshcd_init(dev, &hba, mmio_base, irq);
>   	if (err) {
>   		dev_err(dev, "Intialization failed\n");
> -		goto out;
> +		goto out_disable_rpm;
>   	}
>
>   	platform_set_drvdata(pdev, hba);
>
Santosh, there is a small mistake in this patch which I overlooked
while re-basing my internal tree onto scsi-misc.

We should return from here without falling back to out_disable_rpm.

+	return 0;

or

+	goto out;

I can send a new patchset, but if you would like to fix it in your tree
itself I am okay with it.

> +out_disable_rpm:
> +	pm_runtime_disable(&pdev->dev);
> +	pm_runtime_set_suspended(&pdev->dev);
>   out:
>   	return err;
>   }

-- 
Regards,
Sujit