Re: [Qemu-devel] [PATCH RFT 4/5] virtio-console: Use exitfn for virtserialport, too

["Andreas Färber" <afaerber@suse.de>]

Michael, Anthony,

Am 07.06.2013 20:18, schrieb Andreas Färber:
> virtconsole and virtserialport are identical in every other aspect
> except for the distinguishing VirtIOSerialPortClass::is_console field.
> 
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  hw/char/virtio-console.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/char/virtio-console.c b/hw/char/virtio-console.c
> index 7b1a382..73e18f2 100644
> --- a/hw/char/virtio-console.c
> +++ b/hw/char/virtio-console.c
> @@ -192,6 +192,7 @@ static void virtserialport_class_init(ObjectClass *klass, void *data)
>      VirtIOSerialPortClass *k = VIRTIO_SERIAL_PORT_CLASS(klass);
>  
>      k->init = virtconsole_initfn;
> +    k->exit = virtconsole_exitfn;
>      k->have_data = flush_buf;
>      k->set_guest_connected = set_guest_connected;
>      dc->props = virtserialport_properties;

Ping! Is this a fix we should get into 1.6? Or does it not matter in
practice for some reason?

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg