From: Li Zefan <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Glauber Costa <glommer@parallels.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
LKML <linux-kernel@vger.kernel.org>,
Cgroups <cgroups@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: [PATCH v3 1/8] cgroup: convert cgroup_ida to cgroup_idr
Date: Tue, 30 Jul 2013 09:10:19 +0800 [thread overview]
Message-ID: <51F7127B.1070107@huawei.com> (raw)
In-Reply-To: <20130729182835.GD26076@mtj.dyndns.org>
On 2013/7/30 2:28, Tejun Heo wrote:
> Hello,
>
> On Mon, Jul 29, 2013 at 03:07:48PM +0800, Li Zefan wrote:
>> @@ -4590,6 +4599,9 @@ static void cgroup_offline_fn(struct work_struct *work)
>> /* delete this cgroup from parent->children */
>> list_del_rcu(&cgrp->sibling);
>>
>> + if (cgrp->id)
>> + idr_remove(&cgrp->root->cgroup_idr, cgrp->id);
>> +
>
> Yeap, if we're gonna allow lookups, removal should happen here but can
> we please add short comment explaining why that is?
sure
> Also, do we want to clear cgrp->id?
>
Set cgrp->id to 0? No, 0 is a valid id. The if is here because at first
I called idr_alloc() very late in cgroup_create(), so cgroup_offline_fn()
can be called while cgrp->id hasn't been initialized. Now I can remove
this check.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Glauber Costa <glommer@parallels.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
LKML <linux-kernel@vger.kernel.org>,
Cgroups <cgroups@vger.kernel.org>, <linux-mm@kvack.org>
Subject: Re: [PATCH v3 1/8] cgroup: convert cgroup_ida to cgroup_idr
Date: Tue, 30 Jul 2013 09:10:19 +0800 [thread overview]
Message-ID: <51F7127B.1070107@huawei.com> (raw)
In-Reply-To: <20130729182835.GD26076@mtj.dyndns.org>
On 2013/7/30 2:28, Tejun Heo wrote:
> Hello,
>
> On Mon, Jul 29, 2013 at 03:07:48PM +0800, Li Zefan wrote:
>> @@ -4590,6 +4599,9 @@ static void cgroup_offline_fn(struct work_struct *work)
>> /* delete this cgroup from parent->children */
>> list_del_rcu(&cgrp->sibling);
>>
>> + if (cgrp->id)
>> + idr_remove(&cgrp->root->cgroup_idr, cgrp->id);
>> +
>
> Yeap, if we're gonna allow lookups, removal should happen here but can
> we please add short comment explaining why that is?
sure
> Also, do we want to clear cgrp->id?
>
Set cgrp->id to 0? No, 0 is a valid id. The if is here because at first
I called idr_alloc() very late in cgroup_create(), so cgroup_offline_fn()
can be called while cgrp->id hasn't been initialized. Now I can remove
this check.
next prev parent reply other threads:[~2013-07-30 1:10 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 7:07 [PATCH v3 0/8] memcg, cgroup: kill css_id Li Zefan
2013-07-29 7:07 ` Li Zefan
2013-07-29 7:08 ` [PATCH v3 2/8] cgroup: document how cgroup IDs are assigned Li Zefan
2013-07-29 7:08 ` Li Zefan
2013-07-29 18:26 ` Tejun Heo
2013-07-29 18:26 ` Tejun Heo
[not found] ` <20130729182632.GC26076-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-07-30 1:08 ` Li Zefan
2013-07-30 1:08 ` Li Zefan
2013-07-30 1:08 ` Li Zefan
2013-07-30 14:22 ` Tejun Heo
2013-07-30 14:22 ` Tejun Heo
2013-07-29 7:08 ` [PATCH v3 3/8] cgroup: implement cgroup_from_id() Li Zefan
2013-07-29 7:08 ` Li Zefan
2013-07-29 18:31 ` Tejun Heo
2013-07-29 18:31 ` Tejun Heo
2013-07-29 7:08 ` [PATCH v3 4/8] memcg: convert to use cgroup_is_descendant() Li Zefan
2013-07-29 7:08 ` Li Zefan
2013-07-29 7:08 ` [PATCH v3 5/8] memcg: convert to use cgroup id Li Zefan
2013-07-29 7:08 ` Li Zefan
[not found] ` <51F614B2.6010503-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-07-29 7:07 ` [PATCH v3 1/8] cgroup: convert cgroup_ida to cgroup_idr Li Zefan
2013-07-29 7:07 ` Li Zefan
2013-07-29 7:07 ` Li Zefan
[not found] ` <51F614C4.7060602-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-07-29 18:28 ` Tejun Heo
2013-07-29 18:28 ` Tejun Heo
2013-07-29 18:28 ` Tejun Heo
2013-07-30 1:10 ` Li Zefan [this message]
2013-07-30 1:10 ` Li Zefan
2013-07-30 14:21 ` Tejun Heo
2013-07-30 14:21 ` Tejun Heo
2013-07-29 7:09 ` [PATCH v3 6/8] memcg: fail to create cgroup if the cgroup id is too big Li Zefan
2013-07-29 7:09 ` Li Zefan
2013-07-29 7:09 ` Li Zefan
2013-07-29 7:09 ` [PATCH v3 7/8] memcg: stop using css id Li Zefan
2013-07-29 7:09 ` Li Zefan
2013-07-29 7:09 ` Li Zefan
2013-07-29 7:10 ` [PATCH v3 8/8] cgroup: kill css_id Li Zefan
2013-07-29 7:10 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F7127B.1070107@huawei.com \
--to=lizefan@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=glommer@parallels.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.