All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
To: DAN LI <li.dan@cn.fujitsu.com>
Cc: LTP list <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PATCH] mount/mount06.c: fix a compile error
Date: Tue, 30 Jul 2013 11:40:34 +0800	[thread overview]
Message-ID: <51F735B2.5030007@cn.fujitsu.com> (raw)
In-Reply-To: <51F7338D.4060804@cn.fujitsu.com>

On 07/30/2013 11:31 AM, DAN LI wrote:
> 
> The definitions of MS_PRIVATE and MS_MOVE were only added to glibc headers
> in version 2.12.
> 
> If the version of glibc is older than 2.12, define these two flags.
> 
> Signed-off-by: DAN LI <li.dan@cn.fujitsu.com>
> ---
>  testcases/kernel/syscalls/mount/mount06.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/testcases/kernel/syscalls/mount/mount06.c b/testcases/kernel/syscalls/mount/mount06.c
> index acfb22d..ab1a472 100644
> --- a/testcases/kernel/syscalls/mount/mount06.c
> +++ b/testcases/kernel/syscalls/mount/mount06.c
> @@ -31,6 +31,11 @@
>  #include "usctest.h"
>  #include "safe_macros.h"
> 
> +#if !(__GLIBC_PREREQ(2, 12))

Why not do like below?
#ifndef MS_MOVE
#define xxx
#define xxx
#endif

Wanlong Gao

> +#define MS_MOVE	8192
> +#define MS_PRIVATE	(1 << 18)
> +#endif
> +
>  #define MNTPOINT_SRC	"mnt_src"
>  #define MNTPOINT_DES	"mnt_des"
>  #define LINELENGTH	256
> 


------------------------------------------------------------------------------
Get your SQL database under version control now!
Version control is standard for application code, but databases havent 
caught up. So what steps can you take to put your SQL databases under 
version control? Why should you start doing it? Read more to find out.
http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  reply	other threads:[~2013-07-30  3:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-30  3:31 [LTP] [PATCH] mount/mount06.c: fix a compile error DAN LI
2013-07-30  3:40 ` Wanlong Gao [this message]
2013-07-30  4:16   ` DAN LI
2013-07-30  8:19     ` Benoit Marcot
2013-07-30  8:32       ` Benoit Marcot
2013-07-30  9:59     ` chrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F735B2.5030007@cn.fujitsu.com \
    --to=gaowanlong@cn.fujitsu.com \
    --cc=li.dan@cn.fujitsu.com \
    --cc=ltp-list@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.