Re: [LTP] [PATCH] mount/mount06.c: fix a compile error

[DAN LI <li.dan@cn.fujitsu.com>]

On 07/30/2013 11:40 AM, Wanlong Gao wrote:
> On 07/30/2013 11:31 AM, DAN LI wrote:
>>
>> The definitions of MS_PRIVATE and MS_MOVE were only added to glibc headers
>> in version 2.12.
>>
>> If the version of glibc is older than 2.12, define these two flags.
>>
>> Signed-off-by: DAN LI <li.dan@cn.fujitsu.com>
>> ---
>>  testcases/kernel/syscalls/mount/mount06.c |    5 +++++
>>  1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/testcases/kernel/syscalls/mount/mount06.c b/testcases/kernel/syscalls/mount/mount06.c
>> index acfb22d..ab1a472 100644
>> --- a/testcases/kernel/syscalls/mount/mount06.c
>> +++ b/testcases/kernel/syscalls/mount/mount06.c
>> @@ -31,6 +31,11 @@
>>  #include "usctest.h"
>>  #include "safe_macros.h"
>>
>> +#if !(__GLIBC_PREREQ(2, 12))
> 
> Why not do like below?

I think it also clearly shows the reason why this definition should
exist here(glibc version related).

Regards,
DAN LI

> #ifndef MS_MOVE
> #define xxx
> #define xxx
> #endif
> 
> Wanlong Gao
> 
>> +#define MS_MOVE	8192
>> +#define MS_PRIVATE	(1 << 18)
>> +#endif
>> +
>>  #define MNTPOINT_SRC	"mnt_src"
>>  #define MNTPOINT_DES	"mnt_des"
>>  #define LINELENGTH	256
>>
> 
> 



------------------------------------------------------------------------------
Get your SQL database under version control now!
Version control is standard for application code, but databases havent 
caught up. So what steps can you take to put your SQL databases under 
version control? Why should you start doing it? Read more to find out.
http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list