diff for duplicates of <51F74B20.6070005@ti.com> diff --git a/a/1.txt b/N1/1.txt index 8bd61f1..335f715 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -122,7 +122,7 @@ On Monday 29 July 2013 09:21 PM, Sylwester Nawrocki wrote: > > Don't you need something like > -> if (phy->init_data = NULL) +> if (phy->init_data == NULL) > return ERR_PTR(-EINVAL); > > to ensure there is no attempt to dereference NULL platform data ? @@ -158,7 +158,7 @@ hmm.. perhaps a dev_WARN too.. >> + return ret; >> + >> + mutex_lock(&phy->mutex); ->> + if (phy->init_count++ = 0 && phy->ops->init) { +>> + if (phy->init_count++ == 0 && phy->ops->init) { >> + ret = phy->ops->init(phy); >> + if (ret < 0) { >> + dev_err(&phy->dev, "phy init failed --> %d\n", ret); diff --git a/a/content_digest b/N1/content_digest index fe7b218..e36f24a 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,8 +3,35 @@ "ref\051F68F73.9060603@samsung.com\0" "From\0Kishon Vijay Abraham I <kishon@ti.com>\0" "Subject\0Re: [RESEND PATCH v10 1/8] drivers: phy: add generic PHY framework\0" - "Date\0Tue, 30 Jul 2013 05:24:00 +0000\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "Date\0Tue, 30 Jul 2013 10:42:00 +0530\0" + "To\0Sylwester Nawrocki <s.nawrocki@samsung.com>\0" + "Cc\0linux-fbdev@vger.kernel.org" + linux-doc@vger.kernel.org + tony@atomide.com + Tomasz Figa <t.figa@samsung.com> + nsekhar@ti.com + tomasz.figa@gmail.com + kgene.kim@samsung.com + swarren@nvidia.com + jg1.han@samsung.com + stern@rowland.harvard.edu + grant.likely@linaro.org + linux-media@vger.kernel.org + devicetree@vger.kernel.org + george.cherian@ti.com + arnd@arndb.de + linux-samsung-soc@vger.kernel.org + linux@arm.linux.org.uk + linux-omap@vger.kernel.org + linux-arm-kernel@lists.infradead.org + balajitk@ti.com + gregkh@linuxfoundation.org + linux-usb@vger.kernel.org + linux-kernel@vger.kernel.org + balbi@ti.com + kyungmin.park@samsung.com + broonie@kernel.org + " akpm@linux-foundation.org\0" "\00:1\0" "b\0" "Hi,\n" @@ -131,7 +158,7 @@ "> \t\n" "> Don't you need something like\n" "> \n" - "> \tif (phy->init_data = NULL)\t\n" + "> \tif (phy->init_data == NULL)\t\n" "> \t\treturn ERR_PTR(-EINVAL);\n" "> \n" "> to ensure there is no attempt to dereference NULL platform data ?\n" @@ -167,7 +194,7 @@ ">> +\t\treturn ret;\n" ">> +\n" ">> +\tmutex_lock(&phy->mutex);\n" - ">> +\tif (phy->init_count++ = 0 && phy->ops->init) {\n" + ">> +\tif (phy->init_count++ == 0 && phy->ops->init) {\n" ">> +\t\tret = phy->ops->init(phy);\n" ">> +\t\tif (ret < 0) {\n" ">> +\t\t\tdev_err(&phy->dev, \"phy init failed --> %d\\n\", ret);\n" @@ -179,4 +206,4 @@ "Thanks\n" Kishon -5631a4ed943f920b2b983b291bcdaa2fd661e8ff6645ca50c03aafd820eb0c3f +a6130069d4d819d31be33dd741c782387da2619d68dbcf189f4e456e31910b28
diff --git a/a/1.txt b/N2/1.txt index 8bd61f1..335f715 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -122,7 +122,7 @@ On Monday 29 July 2013 09:21 PM, Sylwester Nawrocki wrote: > > Don't you need something like > -> if (phy->init_data = NULL) +> if (phy->init_data == NULL) > return ERR_PTR(-EINVAL); > > to ensure there is no attempt to dereference NULL platform data ? @@ -158,7 +158,7 @@ hmm.. perhaps a dev_WARN too.. >> + return ret; >> + >> + mutex_lock(&phy->mutex); ->> + if (phy->init_count++ = 0 && phy->ops->init) { +>> + if (phy->init_count++ == 0 && phy->ops->init) { >> + ret = phy->ops->init(phy); >> + if (ret < 0) { >> + dev_err(&phy->dev, "phy init failed --> %d\n", ret); diff --git a/a/content_digest b/N2/content_digest index fe7b218..80f21f3 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,9 +1,9 @@ "ref\01374842963-13545-1-git-send-email-kishon@ti.com\0" "ref\01374842963-13545-2-git-send-email-kishon@ti.com\0" "ref\051F68F73.9060603@samsung.com\0" - "From\0Kishon Vijay Abraham I <kishon@ti.com>\0" - "Subject\0Re: [RESEND PATCH v10 1/8] drivers: phy: add generic PHY framework\0" - "Date\0Tue, 30 Jul 2013 05:24:00 +0000\0" + "From\0kishon@ti.com (Kishon Vijay Abraham I)\0" + "Subject\0[RESEND PATCH v10 1/8] drivers: phy: add generic PHY framework\0" + "Date\0Tue, 30 Jul 2013 10:42:00 +0530\0" "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" @@ -131,7 +131,7 @@ "> \t\n" "> Don't you need something like\n" "> \n" - "> \tif (phy->init_data = NULL)\t\n" + "> \tif (phy->init_data == NULL)\t\n" "> \t\treturn ERR_PTR(-EINVAL);\n" "> \n" "> to ensure there is no attempt to dereference NULL platform data ?\n" @@ -167,7 +167,7 @@ ">> +\t\treturn ret;\n" ">> +\n" ">> +\tmutex_lock(&phy->mutex);\n" - ">> +\tif (phy->init_count++ = 0 && phy->ops->init) {\n" + ">> +\tif (phy->init_count++ == 0 && phy->ops->init) {\n" ">> +\t\tret = phy->ops->init(phy);\n" ">> +\t\tif (ret < 0) {\n" ">> +\t\t\tdev_err(&phy->dev, \"phy init failed --> %d\\n\", ret);\n" @@ -179,4 +179,4 @@ "Thanks\n" Kishon -5631a4ed943f920b2b983b291bcdaa2fd661e8ff6645ca50c03aafd820eb0c3f +6c34121b9b55d5ae008e830b1c8010eebc665d1f1aa046709acab5dd2e462ca5
diff --git a/a/1.txt b/N3/1.txt index 8bd61f1..335f715 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -122,7 +122,7 @@ On Monday 29 July 2013 09:21 PM, Sylwester Nawrocki wrote: > > Don't you need something like > -> if (phy->init_data = NULL) +> if (phy->init_data == NULL) > return ERR_PTR(-EINVAL); > > to ensure there is no attempt to dereference NULL platform data ? @@ -158,7 +158,7 @@ hmm.. perhaps a dev_WARN too.. >> + return ret; >> + >> + mutex_lock(&phy->mutex); ->> + if (phy->init_count++ = 0 && phy->ops->init) { +>> + if (phy->init_count++ == 0 && phy->ops->init) { >> + ret = phy->ops->init(phy); >> + if (ret < 0) { >> + dev_err(&phy->dev, "phy init failed --> %d\n", ret); diff --git a/a/content_digest b/N3/content_digest index fe7b218..d0d7aa7 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -3,8 +3,35 @@ "ref\051F68F73.9060603@samsung.com\0" "From\0Kishon Vijay Abraham I <kishon@ti.com>\0" "Subject\0Re: [RESEND PATCH v10 1/8] drivers: phy: add generic PHY framework\0" - "Date\0Tue, 30 Jul 2013 05:24:00 +0000\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "Date\0Tue, 30 Jul 2013 10:42:00 +0530\0" + "To\0Sylwester Nawrocki <s.nawrocki@samsung.com>\0" + "Cc\0<gregkh@linuxfoundation.org>" + <kyungmin.park@samsung.com> + <balbi@ti.com> + <jg1.han@samsung.com> + <kgene.kim@samsung.com> + <stern@rowland.harvard.edu> + <broonie@kernel.org> + <tomasz.figa@gmail.com> + <arnd@arndb.de> + <devicetree@vger.kernel.org> + <linux-fbdev@vger.kernel.org> + <linux-samsung-soc@vger.kernel.org> + <swarren@nvidia.com> + <balajitk@ti.com> + <linux-doc@vger.kernel.org> + <tony@atomide.com> + Tomasz Figa <t.figa@samsung.com> + <linux-usb@vger.kernel.org> + <nsekhar@ti.com> + <linux-kernel@vger.kernel.org> + <grant.likely@linaro.org> + <linux@arm.linux.org.uk> + <akpm@linux-foundation.org> + <linux-omap@vger.kernel.org> + <george.cherian@ti.com> + <linux-arm-kernel@lists.infradead.org> + " <linux-media@vger.kernel.org>\0" "\00:1\0" "b\0" "Hi,\n" @@ -131,7 +158,7 @@ "> \t\n" "> Don't you need something like\n" "> \n" - "> \tif (phy->init_data = NULL)\t\n" + "> \tif (phy->init_data == NULL)\t\n" "> \t\treturn ERR_PTR(-EINVAL);\n" "> \n" "> to ensure there is no attempt to dereference NULL platform data ?\n" @@ -167,7 +194,7 @@ ">> +\t\treturn ret;\n" ">> +\n" ">> +\tmutex_lock(&phy->mutex);\n" - ">> +\tif (phy->init_count++ = 0 && phy->ops->init) {\n" + ">> +\tif (phy->init_count++ == 0 && phy->ops->init) {\n" ">> +\t\tret = phy->ops->init(phy);\n" ">> +\t\tif (ret < 0) {\n" ">> +\t\t\tdev_err(&phy->dev, \"phy init failed --> %d\\n\", ret);\n" @@ -179,4 +206,4 @@ "Thanks\n" Kishon -5631a4ed943f920b2b983b291bcdaa2fd661e8ff6645ca50c03aafd820eb0c3f +52d3f1300186fafba81ab070037804092204a2672460c74321d7e8b25825f00e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.