From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH 2/2] arm: omap: remove *.auto* from device names given in usb_bind_phy Date: Tue, 30 Jul 2013 10:44:48 +0530 Message-ID: <51F74BC8.7020903@ti.com> References: <1374829418-27503-1-git-send-email-kishon@ti.com> <1374829418-27503-3-git-send-email-kishon@ti.com> <20130729150638.GD3063@radagast> <51F68A56.8060805@ti.com> <20130729175413.GC4964@radagast> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20130729175413.GC4964@radagast> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: balbi@ti.com Cc: linux@arm.linux.org.uk, tony@atomide.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, eballetbo@gmail.com, javier@dowhile0.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org SGksCgpPbiBNb25kYXkgMjkgSnVseSAyMDEzIDExOjI0IFBNLCBGZWxpcGUgQmFsYmkgd3JvdGU6 Cj4gSGksCj4gCj4gT24gTW9uLCBKdWwgMjksIDIwMTMgYXQgMDg6NTk6MjZQTSArMDUzMCwgS2lz aG9uIFZpamF5IEFicmFoYW0gSSB3cm90ZToKPj4+PiBQcmV2aW91c2x5IE1VU0Igd3JhcHBlciAo T01BUCkgZGV2aWNlIHVzZWQgUExBVEZPUk1fREVWSURfQVVUTyB3aGlsZSBjcmVhdGluZwo+Pj4+ IE1VU0IgY29yZSBkZXZpY2UuIFNvIGluIHVzYl9iaW5kX3BoeSAoYmluZHMgdGhlIGNvbnRyb2xs ZXIgd2l0aCB0aGUgUEhZKSwgdGhlCj4+Pj4gZGV2aWNlIG5hbWUgb2YgdGhlIGNvbnRyb2xsZXIg aGFkICouYXV0byogaW4gaXQuIFNpbmNlIHdpdGggdXNpbmcKPj4+PiBQTEFURk9STV9ERVZJRF9B VVRPLCB0aGVyZSBpcyBubyB3YXkgdG8ga25vdyB0aGUgZXhhY3QgZGV2aWNlIG5hbWUgaW4gYWR2 YW5jZSwKPj4+PiB0aGUgZGF0YSBnaXZlbiBpbiB1c2JfYmluZF9waHkgYmVjYW1lIG9ic29sZXRl IGFuZCB1c2JfZ2V0X3BoeSB3YXMgZmFpbGluZy4KPj4+PiBTbyBNVVNCIHdyYXBwZXIgd2FzIG1v ZGlmaWVkIG5vdCB0byB1c2UgUExBVEZPUk1fREVWSURfQVVUTy4gQ29ycmVzcG9uZGluZwo+Pj4+ IGNoYW5nZSBpcyBkb25lIGluIGJvYXJkIGZpbGUgaGVyZS4KPj4+Pgo+Pj4+IFNpZ25lZC1vZmYt Ynk6IEtpc2hvbiBWaWpheSBBYnJhaGFtIEkgPGtpc2hvbkB0aS5jb20+Cj4+Pj4gLS0tCj4+Pj4g IGFyY2gvYXJtL21hY2gtb21hcDIvYm9hcmQtMjQzMHNkcC5jICAgICAgICAgIHwgICAgMiArLQo+ Pj4+ICBhcmNoL2FybS9tYWNoLW9tYXAyL2JvYXJkLTM0MzBzZHAuYyAgICAgICAgICB8ICAgIDIg Ky0KPj4+PiAgYXJjaC9hcm0vbWFjaC1vbWFwMi9ib2FyZC1jbS10MzUuYyAgICAgICAgICAgfCAg ICAyICstCj4+Pj4gIGFyY2gvYXJtL21hY2gtb21hcDIvYm9hcmQtZGV2a2l0ODAwMC5jICAgICAg IHwgICAgMiArLQo+Pj4+ICBhcmNoL2FybS9tYWNoLW9tYXAyL2JvYXJkLWlnZXAwMDIwLmMgICAg ICAgICB8ICAgIDIgKy0KPj4+PiAgYXJjaC9hcm0vbWFjaC1vbWFwMi9ib2FyZC1sZHAuYyAgICAg ICAgICAgICAgfCAgICAyICstCj4+Pj4gIGFyY2gvYXJtL21hY2gtb21hcDIvYm9hcmQtb21hcDNi ZWFnbGUuYyAgICAgIHwgICAgMiArLQo+Pj4+ICBhcmNoL2FybS9tYWNoLW9tYXAyL2JvYXJkLW9t YXAzZXZtLmMgICAgICAgICB8ICAgIDIgKy0KPj4+PiAgYXJjaC9hcm0vbWFjaC1vbWFwMi9ib2Fy ZC1vbWFwM2xvZ2ljLmMgICAgICAgfCAgICAyICstCj4+Pj4gIGFyY2gvYXJtL21hY2gtb21hcDIv Ym9hcmQtb21hcDNwYW5kb3JhLmMgICAgIHwgICAgMiArLQo+Pj4+ICBhcmNoL2FybS9tYWNoLW9t YXAyL2JvYXJkLW9tYXAzc3RhbGtlci5jICAgICB8ICAgIDIgKy0KPj4+PiAgYXJjaC9hcm0vbWFj aC1vbWFwMi9ib2FyZC1vbWFwM3RvdWNoYm9vay5jICAgfCAgICAyICstCj4+Pj4gIGFyY2gvYXJt L21hY2gtb21hcDIvYm9hcmQtb3Zlcm8uYyAgICAgICAgICAgIHwgICAgMiArLQo+Pj4+ICBhcmNo L2FybS9tYWNoLW9tYXAyL2JvYXJkLXJtNjgwLmMgICAgICAgICAgICB8ICAgIDIgKy0KPj4+PiAg YXJjaC9hcm0vbWFjaC1vbWFwMi9ib2FyZC1yeDUxLmMgICAgICAgICAgICAgfCAgICAyICstCj4+ Pj4gIGFyY2gvYXJtL21hY2gtb21hcDIvYm9hcmQtem9vbS1wZXJpcGhlcmFscy5jIHwgICAgMiAr LQo+Pj4+ICAxNiBmaWxlcyBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCAxNiBkZWxldGlvbnMo LSkKPj4+Pgo+Pj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybS9tYWNoLW9tYXAyL2JvYXJkLTI0MzBz ZHAuYyBiL2FyY2gvYXJtL21hY2gtb21hcDIvYm9hcmQtMjQzMHNkcC5jCj4+Pj4gaW5kZXggMjQ0 ZDhhNS4uMTdiYjA3NiAxMDA2NDQKPj4+PiAtLS0gYS9hcmNoL2FybS9tYWNoLW9tYXAyL2JvYXJk LTI0MzBzZHAuYwo+Pj4+ICsrKyBiL2FyY2gvYXJtL21hY2gtb21hcDIvYm9hcmQtMjQzMHNkcC5j Cj4+Pj4gQEAgLTIzMyw3ICsyMzMsNyBAQCBzdGF0aWMgdm9pZCBfX2luaXQgb21hcF8yNDMwc2Rw X2luaXQodm9pZCkKPj4+PiAgCW9tYXBfaHNtbWNfaW5pdChtbWMpOwo+Pj4+ICAKPj4+PiAgCW9t YXBfbXV4X2luaXRfc2lnbmFsKCJ1c2IwaHNfc3RwIiwgT01BUF9QVUxMX0VOQSB8IE9NQVBfUFVM TF9VUCk7Cj4+Pj4gLQl1c2JfYmluZF9waHkoIm11c2ItaGRyYy4wLmF1dG8iLCAwLCAidHdsNDAz MF91c2IiKTsKPj4+PiArCXVzYl9iaW5kX3BoeSgibXVzYi1oZHJjLjAiLCAwLCAidHdsNDAzMF91 c2IiKTsKPj4+Cj4+PiBob3cgYWJvdXQgbW92aW5nIHVzYl9iaW5kX3BoeSgpIGNhbGxzIHRvIG9t YXAyNDMwLmMgPwo+Pj4KPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi9tdXNiL29tYXAyNDMw LmMgYi9kcml2ZXJzL3VzYi9tdXNiL29tYXAyNDMwLmMKPj4+IGluZGV4IGY0NGU4YjUuLmI2YWJj MWEgMTAwNjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL3VzYi9tdXNiL29tYXAyNDMwLmMKPj4+ICsrKyBi L2RyaXZlcnMvdXNiL211c2Ivb21hcDI0MzAuYwo+Pj4gQEAgLTU0NCw2ICs1NDQsOSBAQCBzdGF0 aWMgaW50IG9tYXAyNDMwX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4+PiAg Cj4+PiAgCQlwZGF0YS0+Ym9hcmRfZGF0YQk9IGRhdGE7Cj4+PiAgCQlwZGF0YS0+Y29uZmlnCQk9 IGNvbmZpZzsKPj4+ICsJfSBlbHNlIHsKPj4+ICsJCS8qIGJpbmQgdGhlIFBIWSAqLwo+Pj4gKwkJ dXNiX2JpbmRfcGh5KGRldl9uYW1lKCZtdXNiLT5kZXYpLCAwLCAidHdsNDAzMF91c2IiKTsKPj4K Pj4gVGhpcyBsb29rcyBsaWtlIGEgaGFjayBJTUhPIHRvIHdvcmthcm91bmQgdGhlIHVzYiBwaHkg bGlicmFyeS4gb3RoZXJ3aXNlIGl0IGlzCj4+IHNpbWlsYXIgdG8gZ2V0X3BoeV9ieV9uYW1lLgo+ IAo+IGFjdHVhbGx5LCB0aGlzIGlzIGEgd29ya2Fyb3VuZCB0byB0aGUgZmFjdCB0aGF0IHdlJ3Jl IG5vdCBjcmVhdGluZyBhbGwKPiBwbGF0Zm9ybV9kZXZpY2VzIGluIGFyY2gvYXJtL21hY2gtb21h cDIvIDotKQo+IAo+IElmIHdlIGhhZCB0aGUgbXVzYiBhbGxvY2F0aW9uIHRoZXJlLCB3ZSBjb3Vs ZCBlYXNpbHkgaGFuZGxlCj4gdXNiX2JpbmRfcGh5KCkKPiAKPj4+IHNvIHRoYXQncyB0ZW1wb3Jh cnkuIEl0IG1pZ2h0IGJlIGJldHRlciB0aGFuIHRvIHJlaW50cm9kdWNlIHRoZSBJRFIgaW4KPj4+ IG11c2JfY29yZS5jLgo+Pgo+PiB0aGF04oCZcyBuZWVkZWQgZm9yIGdlbmVyaWMgcGh5IGZyYW1l d29yayBhbnl3YXkgOi1zCj4gCj4gcmlnaHQsIGJ1dCBnZW5lcmljIHBoeSBmcmFtZXdvcmsgY2Fu IGhhbmRsZSBldmVyeXRoaW5nIGp1c3QgZmluZSwgdGhlCj4gb25seSBwcm9ibGVtIGlzIHRoYXQg bmFtZXMgYXJlIGNoYW5naW5nLgoKcmlnaHQuIEJ1dCBpZiB0aGUgbmFtZXMgY2hhbmdlLCBQSFkg ZnJhbWV3b3JrIHdvdWxkbid0IGJlIGFibGUgdG8gcmV0dXJuIHRoZQpyZWZlcmVuY2UgdG8gdGhl IFBIWS4KClRoYW5rcwpLaXNob24KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJu ZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: kishon@ti.com (Kishon Vijay Abraham I) Date: Tue, 30 Jul 2013 10:44:48 +0530 Subject: [PATCH 2/2] arm: omap: remove *.auto* from device names given in usb_bind_phy In-Reply-To: <20130729175413.GC4964@radagast> References: <1374829418-27503-1-git-send-email-kishon@ti.com> <1374829418-27503-3-git-send-email-kishon@ti.com> <20130729150638.GD3063@radagast> <51F68A56.8060805@ti.com> <20130729175413.GC4964@radagast> Message-ID: <51F74BC8.7020903@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Monday 29 July 2013 11:24 PM, Felipe Balbi wrote: > Hi, > > On Mon, Jul 29, 2013 at 08:59:26PM +0530, Kishon Vijay Abraham I wrote: >>>> Previously MUSB wrapper (OMAP) device used PLATFORM_DEVID_AUTO while creating >>>> MUSB core device. So in usb_bind_phy (binds the controller with the PHY), the >>>> device name of the controller had *.auto* in it. Since with using >>>> PLATFORM_DEVID_AUTO, there is no way to know the exact device name in advance, >>>> the data given in usb_bind_phy became obsolete and usb_get_phy was failing. >>>> So MUSB wrapper was modified not to use PLATFORM_DEVID_AUTO. Corresponding >>>> change is done in board file here. >>>> >>>> Signed-off-by: Kishon Vijay Abraham I >>>> --- >>>> arch/arm/mach-omap2/board-2430sdp.c | 2 +- >>>> arch/arm/mach-omap2/board-3430sdp.c | 2 +- >>>> arch/arm/mach-omap2/board-cm-t35.c | 2 +- >>>> arch/arm/mach-omap2/board-devkit8000.c | 2 +- >>>> arch/arm/mach-omap2/board-igep0020.c | 2 +- >>>> arch/arm/mach-omap2/board-ldp.c | 2 +- >>>> arch/arm/mach-omap2/board-omap3beagle.c | 2 +- >>>> arch/arm/mach-omap2/board-omap3evm.c | 2 +- >>>> arch/arm/mach-omap2/board-omap3logic.c | 2 +- >>>> arch/arm/mach-omap2/board-omap3pandora.c | 2 +- >>>> arch/arm/mach-omap2/board-omap3stalker.c | 2 +- >>>> arch/arm/mach-omap2/board-omap3touchbook.c | 2 +- >>>> arch/arm/mach-omap2/board-overo.c | 2 +- >>>> arch/arm/mach-omap2/board-rm680.c | 2 +- >>>> arch/arm/mach-omap2/board-rx51.c | 2 +- >>>> arch/arm/mach-omap2/board-zoom-peripherals.c | 2 +- >>>> 16 files changed, 16 insertions(+), 16 deletions(-) >>>> >>>> diff --git a/arch/arm/mach-omap2/board-2430sdp.c b/arch/arm/mach-omap2/board-2430sdp.c >>>> index 244d8a5..17bb076 100644 >>>> --- a/arch/arm/mach-omap2/board-2430sdp.c >>>> +++ b/arch/arm/mach-omap2/board-2430sdp.c >>>> @@ -233,7 +233,7 @@ static void __init omap_2430sdp_init(void) >>>> omap_hsmmc_init(mmc); >>>> >>>> omap_mux_init_signal("usb0hs_stp", OMAP_PULL_ENA | OMAP_PULL_UP); >>>> - usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb"); >>>> + usb_bind_phy("musb-hdrc.0", 0, "twl4030_usb"); >>> >>> how about moving usb_bind_phy() calls to omap2430.c ? >>> >>> diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c >>> index f44e8b5..b6abc1a 100644 >>> --- a/drivers/usb/musb/omap2430.c >>> +++ b/drivers/usb/musb/omap2430.c >>> @@ -544,6 +544,9 @@ static int omap2430_probe(struct platform_device *pdev) >>> >>> pdata->board_data = data; >>> pdata->config = config; >>> + } else { >>> + /* bind the PHY */ >>> + usb_bind_phy(dev_name(&musb->dev), 0, "twl4030_usb"); >> >> This looks like a hack IMHO to workaround the usb phy library. otherwise it is >> similar to get_phy_by_name. > > actually, this is a workaround to the fact that we're not creating all > platform_devices in arch/arm/mach-omap2/ :-) > > If we had the musb allocation there, we could easily handle > usb_bind_phy() > >>> so that's temporary. It might be better than to reintroduce the IDR in >>> musb_core.c. >> >> that?s needed for generic phy framework anyway :-s > > right, but generic phy framework can handle everything just fine, the > only problem is that names are changing. right. But if the names change, PHY framework wouldn't be able to return the reference to the PHY. Thanks Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757312Ab3G3FPd (ORCPT ); Tue, 30 Jul 2013 01:15:33 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:54217 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753488Ab3G3FPb (ORCPT ); Tue, 30 Jul 2013 01:15:31 -0400 Message-ID: <51F74BC8.7020903@ti.com> Date: Tue, 30 Jul 2013 10:44:48 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: CC: , , , , , , , , Subject: Re: [PATCH 2/2] arm: omap: remove *.auto* from device names given in usb_bind_phy References: <1374829418-27503-1-git-send-email-kishon@ti.com> <1374829418-27503-3-git-send-email-kishon@ti.com> <20130729150638.GD3063@radagast> <51F68A56.8060805@ti.com> <20130729175413.GC4964@radagast> In-Reply-To: <20130729175413.GC4964@radagast> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Monday 29 July 2013 11:24 PM, Felipe Balbi wrote: > Hi, > > On Mon, Jul 29, 2013 at 08:59:26PM +0530, Kishon Vijay Abraham I wrote: >>>> Previously MUSB wrapper (OMAP) device used PLATFORM_DEVID_AUTO while creating >>>> MUSB core device. So in usb_bind_phy (binds the controller with the PHY), the >>>> device name of the controller had *.auto* in it. Since with using >>>> PLATFORM_DEVID_AUTO, there is no way to know the exact device name in advance, >>>> the data given in usb_bind_phy became obsolete and usb_get_phy was failing. >>>> So MUSB wrapper was modified not to use PLATFORM_DEVID_AUTO. Corresponding >>>> change is done in board file here. >>>> >>>> Signed-off-by: Kishon Vijay Abraham I >>>> --- >>>> arch/arm/mach-omap2/board-2430sdp.c | 2 +- >>>> arch/arm/mach-omap2/board-3430sdp.c | 2 +- >>>> arch/arm/mach-omap2/board-cm-t35.c | 2 +- >>>> arch/arm/mach-omap2/board-devkit8000.c | 2 +- >>>> arch/arm/mach-omap2/board-igep0020.c | 2 +- >>>> arch/arm/mach-omap2/board-ldp.c | 2 +- >>>> arch/arm/mach-omap2/board-omap3beagle.c | 2 +- >>>> arch/arm/mach-omap2/board-omap3evm.c | 2 +- >>>> arch/arm/mach-omap2/board-omap3logic.c | 2 +- >>>> arch/arm/mach-omap2/board-omap3pandora.c | 2 +- >>>> arch/arm/mach-omap2/board-omap3stalker.c | 2 +- >>>> arch/arm/mach-omap2/board-omap3touchbook.c | 2 +- >>>> arch/arm/mach-omap2/board-overo.c | 2 +- >>>> arch/arm/mach-omap2/board-rm680.c | 2 +- >>>> arch/arm/mach-omap2/board-rx51.c | 2 +- >>>> arch/arm/mach-omap2/board-zoom-peripherals.c | 2 +- >>>> 16 files changed, 16 insertions(+), 16 deletions(-) >>>> >>>> diff --git a/arch/arm/mach-omap2/board-2430sdp.c b/arch/arm/mach-omap2/board-2430sdp.c >>>> index 244d8a5..17bb076 100644 >>>> --- a/arch/arm/mach-omap2/board-2430sdp.c >>>> +++ b/arch/arm/mach-omap2/board-2430sdp.c >>>> @@ -233,7 +233,7 @@ static void __init omap_2430sdp_init(void) >>>> omap_hsmmc_init(mmc); >>>> >>>> omap_mux_init_signal("usb0hs_stp", OMAP_PULL_ENA | OMAP_PULL_UP); >>>> - usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb"); >>>> + usb_bind_phy("musb-hdrc.0", 0, "twl4030_usb"); >>> >>> how about moving usb_bind_phy() calls to omap2430.c ? >>> >>> diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c >>> index f44e8b5..b6abc1a 100644 >>> --- a/drivers/usb/musb/omap2430.c >>> +++ b/drivers/usb/musb/omap2430.c >>> @@ -544,6 +544,9 @@ static int omap2430_probe(struct platform_device *pdev) >>> >>> pdata->board_data = data; >>> pdata->config = config; >>> + } else { >>> + /* bind the PHY */ >>> + usb_bind_phy(dev_name(&musb->dev), 0, "twl4030_usb"); >> >> This looks like a hack IMHO to workaround the usb phy library. otherwise it is >> similar to get_phy_by_name. > > actually, this is a workaround to the fact that we're not creating all > platform_devices in arch/arm/mach-omap2/ :-) > > If we had the musb allocation there, we could easily handle > usb_bind_phy() > >>> so that's temporary. It might be better than to reintroduce the IDR in >>> musb_core.c. >> >> that’s needed for generic phy framework anyway :-s > > right, but generic phy framework can handle everything just fine, the > only problem is that names are changing. right. But if the names change, PHY framework wouldn't be able to return the reference to the PHY. Thanks Kishon