All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/3] arm, am335x: add support for 3 siemens boards
Date: Tue, 30 Jul 2013 09:13:26 +0200	[thread overview]
Message-ID: <51F76796.5010007@denx.de> (raw)
In-Reply-To: <51F75187.6060607@ti.com>

Hello Lokesh,

Am 30.07.2013 07:39, schrieb Lokesh Vutla:
> Hi Heiko,
> On Tuesday 30 July 2013 10:39 AM, Heiko Schocher wrote:
>> add support for the am335x based boards from siemens:
>>
[...]
>> - [U-Boot] net, phy, cpsw: fix gigabit register access
>>    http://patchwork.ozlabs.org/patch/261087/
> I have just posted a V2 of AM33xx cleanup series, Can you rebase on top of that.
> There was a bug in my series.  Multiplier for DDR DPLL was hard coded for all the boards.
> IN V2, the common file expects  a function which returns ddr_dpll_parms.
> So can you add the following code in your board files:
>
> #define OSC	(V_OSCK/1000000)
> const struct dpll_params dpll_ddr = {
> 		<DXR2_PLL_FREQ>, OSC-1, 1, -1, -1, -1, -1};
> const struct dpll_params *get_dpll_ddr_params(void)
> {
> 		return&dpll_ddr;
> }
>
> The M value we pass in config_ddr is not used(should be cleaned up)
> Please let me know if I am not clear.
> Sorry for the noise...

No problem, thanks for the info... Hmm.. just rebased against
top of u-boot-ti and your patches, but ethernet is not longer
working :-( I get:

U-Boot# ping 192.168.1.1
link up on port 0, speed 1000, full duplex
data abort

     MAYBE you should read doc/README.arm-unaligned-accesses

pc : [<9ff6ed7c>]          lr : [<9ff6f810>]
sp : 9ef40d50  ip : 0019010c     fp : 00000000
r10: 33221100  r9 : 0000002e     r8 : 9ef40f38
r7 : 9ffed56c  r6 : 9ef45db0     r5 : 00000004  r4 : 9ef45d50
r3 : 000005ee  r2 : 9ffee2c0     r1 : 9ef45db0  r0 : 9ef45d50
Flags: nzCv  IRQs off  FIQs on  Mode SVC_32
Resetting CPU ...

resetting ...

U-Boot SPL 2013.07-00098-g2b19a9e (Jul 30 2013 - 09:00:03)

Digging in this ...

Hmm... @tom:

My patch:
[U-Boot] net, phy, cpsw: fix gigabit register access
http://patchwork.ozlabs.org/patch/261087/

has the following diff:
drivers/net/cpsw.c    | 2 +-
  drivers/net/phy/phy.c | 6 +++++-
  2 Dateien ge?ndert, 6 Zeilen hinzugef?gt(+), 2 Zeilen entfernt(-)

Looking in u-boot-ti tree it has:
http://git.denx.de/?p=u-boot/u-boot-ti.git;a=commitdiff;h=7614ef78db2edcfb174da6a21a6756f5de08cc8e

it changes also boards.cfg !? There went something wrong while applying
this patch ... Could you have a look at this issue?

Thanks.

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2013-07-30  7:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-30  5:09 [U-Boot] [PATCH v2 0/3] arm, am335x: add support for siemens boards Heiko Schocher
2013-07-30  5:09 ` [U-Boot] [PATCH v2 1/3] arm, spl: add watchdog library to SPL Heiko Schocher
2013-07-30  5:09 ` [U-Boot] [PATCH v3 2/3] arm, am335x: add watchdog support Heiko Schocher
2013-07-30  5:09 ` [U-Boot] [PATCH v2 3/3] arm, am335x: add support for 3 siemens boards Heiko Schocher
2013-07-30  5:39   ` Lokesh Vutla
2013-07-30  7:13     ` Heiko Schocher [this message]
2013-07-30  7:23       ` Heiko Schocher
2013-07-31 13:25       ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F76796.5010007@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.