From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McGarry Subject: Re: Small fix for ceph.spec Date: Mon, 29 Jul 2013 19:29:34 -0400 Message-ID: References: <51F6F595.605@logtenberg.eu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1103116512==" Return-path: In-Reply-To: <51F6F595.605-nLcryBYLV+bMkAkIaI5Geg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ceph-users-bounces-idqoXFIVOFJgJs9I8MT0rw@public.gmane.org Sender: ceph-users-bounces-idqoXFIVOFJgJs9I8MT0rw@public.gmane.org To: Erik Logtenberg Cc: "ceph-users-idqoXFIVOFJgJs9I8MT0rw@public.gmane.org" , Ceph Devel List-Id: ceph-devel.vger.kernel.org --===============1103116512== Content-Type: multipart/alternative; boundary=047d7b2e3df27e625a04e2aedd53 --047d7b2e3df27e625a04e2aedd53 Content-Type: text/plain; charset=ISO-8859-1 Thanks Erik! Adding ceph-devel since it has a patch on it. Best Regards, Patrick McGarry Director, Community || Inktank http://ceph.com || http://inktank.com @scuttlemonkey || @ceph || @inktank On Mon, Jul 29, 2013 at 7:07 PM, Erik Logtenberg wrote: > Hi, > > The spec file used for building rpm's misses a build time dependency on > snappy-devel. Please see attached patch to fix. > > Kind regards, > > Erik. > > _______________________________________________ > ceph-users mailing list > ceph-users-idqoXFIVOFJgJs9I8MT0rw@public.gmane.org > http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com > > --047d7b2e3df27e625a04e2aedd53 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Thanks Erik!=A0

Adding ceph-devel since= it has a patch on it.



Best Regards,<= /div>

Patrick McGarry
Director, Community || Inktank
http://ceph.com =A0|| =A0http://inktank.com
@scuttlemonk= ey || @ceph || @inktank


On Mon, Jul 29, 2013 at 7:07 PM, Erik Lo= gtenberg <erik-nLcryBYLV+bMkAkIaI5Geg@public.gmane.org> wrote:
Hi,

The spec file used for building rpm's misses a build time dependency on=
snappy-devel. Please see attached patch to fix.

Kind regards,

Erik.

_______________________________________________
ceph-users mailing list
ceph-users-idqoXFIVOFJgJs9I8MT0rw@public.gmane.org<= br> http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com


--047d7b2e3df27e625a04e2aedd53-- --===============1103116512== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ceph-users mailing list ceph-users-idqoXFIVOFJgJs9I8MT0rw@public.gmane.org http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com --===============1103116512==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McGarry Subject: Fwd: [ceph-users] Small fix for ceph.spec Date: Mon, 29 Jul 2013 19:33:18 -0400 Message-ID: References: <51F6F595.605@logtenberg.eu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=bcaec53050e1cf3f7804e2aeea41 Return-path: Received: from mail-pa0-f50.google.com ([209.85.220.50]:47634 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750946Ab3G2XdT (ORCPT ); Mon, 29 Jul 2013 19:33:19 -0400 Received: by mail-pa0-f50.google.com with SMTP id fb10so5948921pad.37 for ; Mon, 29 Jul 2013 16:33:18 -0700 (PDT) In-Reply-To: <51F6F595.605@logtenberg.eu> Sender: ceph-devel-owner@vger.kernel.org List-ID: To: Ceph Devel --bcaec53050e1cf3f7804e2aeea41 Content-Type: text/plain; charset=ISO-8859-1 ---------- Forwarded message ---------- From: Erik Logtenberg Date: Mon, Jul 29, 2013 at 7:07 PM Subject: [ceph-users] Small fix for ceph.spec To: ceph-users@lists.ceph.com Hi, The spec file used for building rpm's misses a build time dependency on snappy-devel. Please see attached patch to fix. Kind regards, Erik. _______________________________________________ ceph-users mailing list ceph-users@lists.ceph.com http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com --bcaec53050e1cf3f7804e2aeea41 Content-Type: text/x-patch; charset=US-ASCII; name="require-snappy-devel.patch" Content-Disposition: attachment; filename="require-snappy-devel.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: abe371e6e77e1bc7_0.1 LS0tIGNlcGguc3BlYy1vcmlnCTIwMTMtMDctMzAgMDA6MjQ6NTQuNzA1MDAwMDAwICswMjAwDQor KysgY2VwaC5zcGVjCTIwMTMtMDctMzAgMDA6MjU6MzQuMTk5MDAwMDAwICswMjAwDQpAQCAtNDIs NiArNDIsNyBAQA0KIEJ1aWxkUmVxdWlyZXM6ICBsaWJ4bWwyLWRldmVsDQogQnVpbGRSZXF1aXJl czogIGxpYnV1aWQtZGV2ZWwNCiBCdWlsZFJlcXVpcmVzOiAgbGV2ZWxkYi1kZXZlbCA+IDEuMg0K K0J1aWxkUmVxdWlyZXM6ICBzbmFwcHktZGV2ZWwNCiANCiAjIyMjIyMjIyMjIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj IyMNCiAjIHNwZWNpZmljDQo= --bcaec53050e1cf3f7804e2aeea41-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Danny Al-Gaaf Subject: Re: Fwd: Small fix for ceph.spec Date: Tue, 30 Jul 2013 09:29:07 +0200 Message-ID: <51F76B43.4020801@bisect.de> References: <51F6F595.605@logtenberg.eu> Reply-To: Danny Al-Gaaf Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ceph-users-bounces-idqoXFIVOFJgJs9I8MT0rw@public.gmane.org Sender: ceph-users-bounces-idqoXFIVOFJgJs9I8MT0rw@public.gmane.org To: Patrick McGarry Cc: Ceph Devel , ceph-users-idqoXFIVOFJgJs9I8MT0rw@public.gmane.org List-Id: ceph-devel.vger.kernel.org Hi, I think this is a bug in packaging of the leveldb package in this case since the spec-file already sets dependencies on on leveldb-devel. leveldb depends on snappy, therefore the leveldb package should set a dependency on snappy-devel for leveldb-devel (check the SUSE spec file for leveldb: https://build.opensuse.org/package/view_file/home:dalgaaf:ceph:extra/leveldb/leveldb.spec?expand=1). This way the RPM build process will pick up the correct packages needed to build ceph. Which distro do you use? Danny Am 30.07.2013 01:33, schrieb Patrick McGarry: > ---------- Forwarded message ---------- > From: Erik Logtenberg > Date: Mon, Jul 29, 2013 at 7:07 PM > Subject: [ceph-users] Small fix for ceph.spec > To: ceph-users-idqoXFIVOFJgJs9I8MT0rw@public.gmane.org > > > Hi, > > The spec file used for building rpm's misses a build time dependency on > snappy-devel. Please see attached patch to fix. > > Kind regards, > > Erik. > > _______________________________________________ > ceph-users mailing list > ceph-users-idqoXFIVOFJgJs9I8MT0rw@public.gmane.org > http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Erik Logtenberg Subject: Re: Fwd: Small fix for ceph.spec Date: Tue, 30 Jul 2013 09:42:01 +0200 Message-ID: <51F76E49.2090504@logtenberg.eu> References: <51F6F595.605@logtenberg.eu> <51F76B43.4020801@bisect.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51F76B43.4020801-2YacvwyR+KOzQB+pC5nmwQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ceph-users-bounces-idqoXFIVOFJgJs9I8MT0rw@public.gmane.org Sender: ceph-users-bounces-idqoXFIVOFJgJs9I8MT0rw@public.gmane.org To: Danny Al-Gaaf Cc: Ceph Devel , ceph-users-idqoXFIVOFJgJs9I8MT0rw@public.gmane.org List-Id: ceph-devel.vger.kernel.org Hi, Fedora, in this case Fedora 19, x86_64. Kind regards, Erik. On 07/30/2013 09:29 AM, Danny Al-Gaaf wrote: > Hi, > > I think this is a bug in packaging of the leveldb package in this case > since the spec-file already sets dependencies on on leveldb-devel. > > leveldb depends on snappy, therefore the leveldb package should set a > dependency on snappy-devel for leveldb-devel (check the SUSE spec file > for leveldb: > https://build.opensuse.org/package/view_file/home:dalgaaf:ceph:extra/leveldb/leveldb.spec?expand=1). > This way the RPM build process will pick up the correct packages needed > to build ceph. > > Which distro do you use? > > Danny > > Am 30.07.2013 01:33, schrieb Patrick McGarry: >> ---------- Forwarded message ---------- >> From: Erik Logtenberg >> Date: Mon, Jul 29, 2013 at 7:07 PM >> Subject: [ceph-users] Small fix for ceph.spec >> To: ceph-users-idqoXFIVOFJgJs9I8MT0rw@public.gmane.org >> >> >> Hi, >> >> The spec file used for building rpm's misses a build time dependency on >> snappy-devel. Please see attached patch to fix. >> >> Kind regards, >> >> Erik. >> >> _______________________________________________ >> ceph-users mailing list >> ceph-users-idqoXFIVOFJgJs9I8MT0rw@public.gmane.org >> http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com >> From mboxrd@z Thu Jan 1 00:00:00 1970 From: Danny Al-Gaaf Subject: Re: Fwd: [ceph-users] Small fix for ceph.spec Date: Tue, 30 Jul 2013 09:56:34 +0200 Message-ID: <51F771B2.1080606@bisect.de> References: <51F6F595.605@logtenberg.eu> <51F76B43.4020801@bisect.de> <51F76E49.2090504@logtenberg.eu> Reply-To: Danny Al-Gaaf Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: Received: from wp188.webpack.hosteurope.de ([80.237.132.195]:45223 "EHLO wp188.webpack.hosteurope.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753030Ab3G3H4i (ORCPT ); Tue, 30 Jul 2013 03:56:38 -0400 In-Reply-To: <51F76E49.2090504@logtenberg.eu> Sender: ceph-devel-owner@vger.kernel.org List-ID: To: Erik Logtenberg Cc: Patrick McGarry , Ceph Devel , ceph-users@lists.ceph.com Hi, then the Fedora package is broken. If you check the spec file of: http://dl.fedoraproject.org/pub/fedora/linux/updates/19/SRPMS/leveldb-1.12.0-3.fc19.src.rpm You can see the spec-file sets a: BuildRequires: snappy-devel But not the corresponding "Requires: snappy-devel" for the devel package. You should report this issue to your distribution, it needs to be fixed there instead of adding a workaround to the ceph spec. Regards, Danny Am 30.07.2013 09:42, schrieb Erik Logtenberg: > Hi, > > Fedora, in this case Fedora 19, x86_64. > > Kind regards, > > Erik. > > > On 07/30/2013 09:29 AM, Danny Al-Gaaf wrote: >> Hi, >> >> I think this is a bug in packaging of the leveldb package in this case >> since the spec-file already sets dependencies on on leveldb-devel. >> >> leveldb depends on snappy, therefore the leveldb package should set a >> dependency on snappy-devel for leveldb-devel (check the SUSE spec file >> for leveldb: >> https://build.opensuse.org/package/view_file/home:dalgaaf:ceph:extra/leveldb/leveldb.spec?expand=1). >> This way the RPM build process will pick up the correct packages needed >> to build ceph. >> >> Which distro do you use? >> >> Danny >> >> Am 30.07.2013 01:33, schrieb Patrick McGarry: >>> ---------- Forwarded message ---------- >>> From: Erik Logtenberg >>> Date: Mon, Jul 29, 2013 at 7:07 PM >>> Subject: [ceph-users] Small fix for ceph.spec >>> To: ceph-users@lists.ceph.com >>> >>> >>> Hi, >>> >>> The spec file used for building rpm's misses a build time dependency on >>> snappy-devel. Please see attached patch to fix. >>> >>> Kind regards, >>> >>> Erik. >>> >>> _______________________________________________ >>> ceph-users mailing list >>> ceph-users@lists.ceph.com >>> http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com >>> > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Erik Logtenberg Subject: Re: Fwd: [ceph-users] Small fix for ceph.spec Date: Tue, 30 Jul 2013 23:01:28 +0200 Message-ID: <51F829A8.104@logtenberg.eu> References: <51F6F595.605@logtenberg.eu> <51F76B43.4020801@bisect.de> <51F76E49.2090504@logtenberg.eu> <51F771B2.1080606@bisect.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mx.logtenberg.eu ([77.94.249.229]:53043 "EHLO mx.logtenberg.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757041Ab3G3VBa (ORCPT ); Tue, 30 Jul 2013 17:01:30 -0400 In-Reply-To: <51F771B2.1080606@bisect.de> Sender: ceph-devel-owner@vger.kernel.org List-ID: To: Danny Al-Gaaf Cc: Patrick McGarry , Ceph Devel , ceph-users@lists.ceph.com Hi, I will report the issue there as well. Please note that Ceph seems to support Fedora 17, even though that release is considered end-of-life by Fedora. This issue with the leveldb package cannot be fixed for Fedora 17, only for 18 and 19. So if Ceph wants to continue supporting Fedora 17, adding this workaround seems to be the only way to get this (rather minor) bug fixed. Kind regards, Erik. On 07/30/2013 09:56 AM, Danny Al-Gaaf wrote: > Hi, > > then the Fedora package is broken. If you check the spec file of: > > http://dl.fedoraproject.org/pub/fedora/linux/updates/19/SRPMS/leveldb-1.12.0-3.fc19.src.rpm > > > You can see the spec-file sets a: > > BuildRequires: snappy-devel > > But not the corresponding "Requires: snappy-devel" for the devel package. > > You should report this issue to your distribution, it needs to be fixed > there instead of adding a workaround to the ceph spec. > > Regards, > > Danny > > Am 30.07.2013 09:42, schrieb Erik Logtenberg: >> Hi, >> >> Fedora, in this case Fedora 19, x86_64. >> >> Kind regards, >> >> Erik. >> >> >> On 07/30/2013 09:29 AM, Danny Al-Gaaf wrote: >>> Hi, >>> >>> I think this is a bug in packaging of the leveldb package in this case >>> since the spec-file already sets dependencies on on leveldb-devel. >>> >>> leveldb depends on snappy, therefore the leveldb package should set a >>> dependency on snappy-devel for leveldb-devel (check the SUSE spec file >>> for leveldb: >>> https://build.opensuse.org/package/view_file/home:dalgaaf:ceph:extra/leveldb/leveldb.spec?expand=1). >>> This way the RPM build process will pick up the correct packages needed >>> to build ceph. >>> >>> Which distro do you use? >>> >>> Danny >>> >>> Am 30.07.2013 01:33, schrieb Patrick McGarry: >>>> ---------- Forwarded message ---------- >>>> From: Erik Logtenberg >>>> Date: Mon, Jul 29, 2013 at 7:07 PM >>>> Subject: [ceph-users] Small fix for ceph.spec >>>> To: ceph-users@lists.ceph.com >>>> >>>> >>>> Hi, >>>> >>>> The spec file used for building rpm's misses a build time dependency on >>>> snappy-devel. Please see attached patch to fix. >>>> >>>> Kind regards, >>>> >>>> Erik. >>>> >>>> _______________________________________________ >>>> ceph-users mailing list >>>> ceph-users@lists.ceph.com >>>> http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com >>>> >>