From: Yang Yingliang <yangyingliang@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: <fubar@us.ibm.com>, <andy@greyhouse.net>, <netdev@vger.kernel.org>
Subject: Re: [PATCH] bonding: set correct tx_queue_len for bond_dev
Date: Tue, 30 Jul 2013 17:24:54 +0800 [thread overview]
Message-ID: <51F78666.3050801@huawei.com> (raw)
In-Reply-To: <20130730.003403.299786235452826263.davem@davemloft.net>
On 2013/7/30 15:34, David Miller wrote:
> From: Yang Yingliang <yangyingliang@huawei.com>
> Date: Tue, 30 Jul 2013 15:20:42 +0800
>
>> With htb, sch->limit is set from bond_dev->tx_queue_len which
>> is initialized to 0 in bond_setup.
>
> This is intentional, software devices should not queue TX
> packets.
This makes software devices with htb qdisc can hold only
one packet, others are dropped.
Maybe sch->limit's default value which is 1 is too small.
Instead of this patch, I'll send another patch to fix this
value for fixing this issue.
>
> You can only use the packet scheduler with hardware devices.
>
>
prev parent reply other threads:[~2013-07-30 9:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 7:20 [PATCH] bonding: set correct tx_queue_len for bond_dev Yang Yingliang
2013-07-30 7:34 ` David Miller
2013-07-30 9:24 ` Yang Yingliang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F78666.3050801@huawei.com \
--to=yangyingliang@huawei.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.