From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 08/10] ASoC: dapm: Add snd_soc_dapm_add_path() helper function
Date: Tue, 30 Jul 2013 13:35:02 +0200 [thread overview]
Message-ID: <51F7A4E6.3030708@metafoo.de> (raw)
In-Reply-To: <20130729174517.GA9858@sirena.org.uk>
On 07/29/2013 07:45 PM, Mark Brown wrote:
> On Mon, Jul 29, 2013 at 05:14:02PM +0200, Lars-Peter Clausen wrote:
>> snd_soc_dapm_add_path() is similar to snd_soc_dapm_add_route() except that it
>> expects the pointer to the source and sink widgets instead of their names. This
>> allows us to simplify the case where we already have a pointer to widgets. (E.g.
>> as we have in snd_soc_dapm_link_dai_widgets()). snd_soc_dapm_add_route() will be
>> updated to just look up the widget and then use snd_soc_dapm_add_path() to
>> handle everything else.
>
> I've applied everything up to patch 9, this is all really good stuff.
> This one would've been a bit easier to review if the refactoring were
> split out from the changes to the users (who could've continued to use
> add_route() for the time being).
>
> Patch 10 I want to have a bit more of a think about and probably try
> using it in something.
I do have a driver that uses the auto-disable feature. The plan is to submit
the driver soonish. I can resend patch 10 as part of the patch series that
adds the driver if necessary.
- Lars
next prev parent reply other threads:[~2013-07-30 11:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 15:13 [PATCH 01/10] ASoC: dapm: Move snd_soc_dapm_update from dapm context to card Lars-Peter Clausen
2013-07-29 15:13 ` [PATCH 02/10] ASoC: dapm: Pass card instead of dapm context to dapm_power_widgets() Lars-Peter Clausen
2013-07-29 15:13 ` [PATCH 03/10] ASoC: dapm: Add a helper to get the CODEC for DAPM kcontrol Lars-Peter Clausen
2013-07-29 15:13 ` [PATCH 04/10] ASoC: dapm: Wrap kcontrol widget list access Lars-Peter Clausen
2013-07-29 15:13 ` [PATCH 05/10] ASoC: dapm: Move 'value' field from widget to control Lars-Peter Clausen
2013-07-29 15:14 ` [PATCH 06/10] ASoC: dapm: Keep a list of paths per kcontrol Lars-Peter Clausen
2013-07-29 15:14 ` [PATCH 07/10] ASoC: dapm: Make widget power register settings more flexible Lars-Peter Clausen
2013-07-29 15:14 ` [PATCH 08/10] ASoC: dapm: Add snd_soc_dapm_add_path() helper function Lars-Peter Clausen
2013-07-29 17:45 ` Mark Brown
2013-07-30 11:35 ` Lars-Peter Clausen [this message]
2013-07-29 15:14 ` [PATCH 09/10] ASoC: dapm: Delay w->power update until the changes are written Lars-Peter Clausen
2013-07-29 15:14 ` [PATCH 10/10] ASoC: dapm: Implement mixer input auto-disable Lars-Peter Clausen
2013-08-01 10:48 ` Mark Brown
2013-08-01 19:24 ` Lars-Peter Clausen
2013-08-02 9:53 ` Mark Brown
2013-08-02 10:22 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F7A4E6.3030708@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.