From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33659) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V48qk-0006y7-2T for qemu-devel@nongnu.org; Tue, 30 Jul 2013 08:16:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V48qc-0001so-Og for qemu-devel@nongnu.org; Tue, 30 Jul 2013 08:16:21 -0400 Received: from cantor2.suse.de ([195.135.220.15]:58425 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V48qc-0001sd-IT for qemu-devel@nongnu.org; Tue, 30 Jul 2013 08:16:14 -0400 Message-ID: <51F7AE88.5040204@suse.de> Date: Tue, 30 Jul 2013 14:16:08 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1375170777-31457-1-git-send-email-famz@redhat.com> <1375170777-31457-4-git-send-email-famz@redhat.com> In-Reply-To: <1375170777-31457-4-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 3/7] block: implement reference count for BlockDriverState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, stefanha@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, Anthony Liguori , Paolo Bonzini Am 30.07.2013 09:52, schrieb Fam Zheng: > Introduce bdrv_ref/bdrv_unref to manage the lifecycle of > BlockDriverState. They are unused for now but will used to replace > bdrv_delete() later. >=20 > Signed-off-by: Fam Zheng > --- > block.c | 22 ++++++++++++++++++++++ > include/block/block.h | 2 ++ > include/block/block_int.h | 1 + > 3 files changed, 25 insertions(+) Didn't Kevin and Markus look into turning BlockDriverState into QOM objects a while back? That would give you reference counting for free, even atomic unlike this patch. MemoryRegion resorted to reference counting on the owner object that was added for the purpose. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg