From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Dawes Subject: Re: [PATCH - Preliminary support for Xonar Xense (resubmitAdded support for Xonar Xense. Only speaker out and mic in working. Date: Tue, 30 Jul 2013 17:41:15 +0100 Message-ID: <51F7ECAB.7050504@gmail.com> References: <1375119909-24454-1-git-send-email-madeallup.gen@gmail.com> <51F6C969.7050504@ladisch.de> <20130729212503.04107489@mainbox> <51F6D131.8040106@ladisch.de> <20130729214039.6d673367@mainbox> <51F75F01.6000607@ladisch.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51F75F01.6000607@ladisch.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Clemens Ladisch Cc: alsa-devel@alsa-project.org, patch@alsa-project.org List-Id: alsa-devel@alsa-project.org On 30/07/13 07:36, Clemens Ladisch wrote: > Ian Dawes wrote: >> Clemens Ladisch wrote: >>> Ian Dawes wrote: >>>> Clemens Ladisch wrote: >>>>> Ian Dawes wrote: >>>>>> Signed-off-by: Ian Dawes >>>>> The commit message was squashed into the subject line. There's >>>>> probably an empty line missing between them. >>>> I'm not sure what this means. >>> Did you intend for the subject to be this long? >> Probably not. I added "resubmitted" to the subject > And the "Added support ..." was supposed to be in the subject, too? > >> How should I rectify this? > Ensure there is an empty line after the subject. Should I resubmit the patch then? (with the additional channels removed and fixed subject line) > > > Regards, > Clemens Apologies for my stupid questions! :)