All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 00/24] Add python3 recipes
Date: Tue, 30 Jul 2013 09:45:59 -0700	[thread overview]
Message-ID: <51F7EDC7.1050105@linux.intel.com> (raw)
In-Reply-To: <45F76803-CA83-4DAC-A972-EE4CB8FEE054@gmail.com>

On 07/30/2013 01:16 AM, Khem Raj wrote:
>
> On Jun 29, 2013, at 8:31 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
>
>> On Sat, Jun 29, 2013 at 07:11:35AM -0700, Khem Raj wrote:
>>>
>>> On Jun 28, 2013, at 10:38 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
>>>
>>>> On Fri, Jun 28, 2013 at 03:03:39PM -0700, Khem Raj wrote:
>>>>>
>>>>> generate-manifest-3.3.py: Add script to generate python 3.3 manifests
>>>>> python-3.3-manifest: Add python3 manifest file
>>>>
>>>>> classes: Add distutils for python3
>>>>> setuptools.bbclass: Use python-distribute instead of
>>>>>    python-setuptools
>>>>> distutils3.bbclass: Port the distutils class fix to handle filenames
>>>>>    with spaces
>>>>> setuptools3.bbclass: Remove useless multiline comment
>>>>> distutils: Introduce PYTHON_ABI variable
>>>>> distutils3: Do build_ext as separate step during compile
>>>>
>>>
>>>> I think these 2 groups could be squashed together for easier review, but
>>>
>>> do you mean create just two patches out of those ?
>>
>> Yes
>>
>>>> otherwise great work, thanks for doing it!
>>>>
>>>> I'll add them to jenkins a bit later when I get some better build that
>>>> what we have now.
>>>
>>> They were added in order that the build keeps working with every commit for helping bisects on tree later
>>
>> I meant that e.g.
>>   classes: Add distutils for python3
>> introduces setuptools3.bbclass and
>>   setuptools3.bbclass: Remove useless multiline comment
>> just 3 commits later fixes that, the same with the left-over commit I
>> mentined in other thread which was also resolved by some follow up
>> commit, with all new .bbclasses together I would read them just once.
>>
>
> Thanks Martin and Paul for reviewing and trying out the patches
> Finally I have now addressed all the comments/feedback that was provided for this patch set.
> The pull tree is now updated to latest.
>
> Take a look and install if its ok
>
Please review your patches for Upstream-Status: and Signed-off-by: tags.

I will be reviewing and building this on the AB in mut.


Sau!

> -Khem
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>


  reply	other threads:[~2013-07-30 16:46 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-28 21:59 [PATCH 00/24] Add python3 recipes Khem Raj
2013-06-28 22:03 ` [PATCH 01/24] generate-manifest-3.3.py: Add script to generate python 3.3 manifests Khem Raj
2013-06-28 22:03 ` [PATCH 02/24] python3native.bbclass: Add python3 abstraction class Khem Raj
2013-06-28 22:03 ` [PATCH 03/24] package_rpm.bbclass:Make the regexp less greedy Khem Raj
2013-06-28 22:03 ` [PATCH 04/24] classes/distutils: Introduce PYTHON_PN Khem Raj
2013-06-29  5:29   ` Martin Jansa
2013-06-29 14:07     ` Khem Raj
2013-06-28 22:03 ` [PATCH 05/24] classes: Add distutils for python3 Khem Raj
2013-06-28 22:03 ` [PATCH 06/24] setuptools.bbclass: Use python-distribute instead of python-setuptools Khem Raj
2013-06-28 22:03 ` [PATCH 07/24] distutils3.bbclass: Port the distutils class fix to handle filenames with spaces Khem Raj
2013-06-28 22:03 ` [PATCH 08/24] setuptools3.bbclass: Remove useless multiline comment Khem Raj
2013-06-28 22:03 ` [PATCH 09/24] distutils: Introduce PYTHON_ABI variable Khem Raj
2013-06-28 22:03 ` [PATCH 10/24] distutils3: Do build_ext as separate step during compile Khem Raj
2013-06-28 22:03 ` [PATCH 11/24] python-3.3-manifest: Add python3 manifest file Khem Raj
2013-06-28 22:03 ` [PATCH 12/24] python3: Add recipes Khem Raj
2013-08-26 13:32   ` Martin Jansa
2013-08-26 17:38     ` Khem Raj
2013-08-27  5:23     ` Khem Raj
2013-08-27  7:45       ` Martin Jansa
2013-08-27  7:48         ` Martin Jansa
2013-08-27 18:10           ` Khem Raj
2013-08-27 18:15             ` Martin Jansa
2013-08-28  6:23               ` Khem Raj
2013-06-28 22:03 ` [PATCH 13/24] python3: Add native recipe Khem Raj
2013-06-28 22:03 ` [PATCH 14/24] python_2.7.3.bb: Inherit python-dir Khem Raj
2013-06-28 22:04 ` [PATCH 15/24] ipython: Add recipes for ipython2 and ipython3 Khem Raj
2013-06-28 22:04 ` [PATCH 16/24] python-distribute: Add recipes for python2 and python3 Khem Raj
2013-07-08 10:49   ` Martin Jansa
2013-06-28 22:04 ` [PATCH 17/24] zeromq: Add recipe Khem Raj
2013-06-28 22:04 ` [PATCH 18/24] pyzmq: Add recipes using python3 Khem Raj
2013-06-28 22:04 ` [PATCH 19/24] python3-pycurl: Add recipe Khem Raj
2013-07-08 10:44   ` Martin Jansa
2013-06-28 22:04 ` [PATCH 20/24] python3-docutils: " Khem Raj
2013-06-28 22:04 ` [PATCH 21/24] python3-jinja: Recipe for python3 templating system Khem Raj
2013-06-30 10:30   ` Martin Jansa
2013-06-28 22:04 ` [PATCH 22/24] python3-nose: Testing tools for python Khem Raj
2013-06-28 22:04 ` [PATCH 23/24] python3-sphinx: New recipe for documentation system Khem Raj
2013-06-28 22:04 ` [PATCH 24/24] python3: Upgrade to 3.3.2 Khem Raj
2013-07-08 10:37   ` Paul Eggleton
2013-06-29  5:38 ` [PATCH 00/24] Add python3 recipes Martin Jansa
2013-06-29 14:11   ` Khem Raj
2013-06-29 15:31     ` Martin Jansa
2013-06-29 17:43       ` Khem Raj
2013-07-30  8:16       ` Khem Raj
2013-07-30 16:45         ` Saul Wold [this message]
2013-07-30 18:28           ` Khem Raj
2013-07-31 20:40         ` Saul Wold
2013-07-31 20:59           ` Khem Raj
2013-07-31 22:31             ` Khem Raj
2013-07-31 22:49               ` Saul Wold
2013-07-31 22:51                 ` Khem Raj
2013-07-31 23:05                   ` Saul Wold
2013-08-01  4:32                     ` Khem Raj
2013-08-01 14:47                     ` Khem Raj
2013-08-01 20:19                     ` Khem Raj
2013-08-02  4:53                       ` Saul Wold
2013-08-02  7:27                         ` Khem Raj
2013-08-03 22:28                           ` Saul Wold
2013-08-05  5:10                             ` Saul Wold
2013-08-05 17:50                               ` Khem Raj
2013-08-06  5:29                               ` Khem Raj
2013-08-07  4:57                         ` Khem Raj
2013-07-08 10:37 ` Paul Eggleton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F7EDC7.1050105@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.