From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50955)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1V4DWC-0007p4-U7
	for qemu-devel@nongnu.org; Tue, 30 Jul 2013 13:15:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1V4DW6-0006C6-DS
	for qemu-devel@nongnu.org; Tue, 30 Jul 2013 13:15:28 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54239)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1V4DW6-0006Bw-2p
	for qemu-devel@nongnu.org; Tue, 30 Jul 2013 13:15:22 -0400
Message-ID: <51F7F4A3.9060504@redhat.com>
Date: Tue, 30 Jul 2013 19:15:15 +0200
From: Hans de Goede <hdegoede@redhat.com>
MIME-Version: 1.0
References: <33183CC9F5247A488A2544077AF190207EF5D6D2@szxeml538-mbx.china.huawei.com>
	<51ED2C93.5050103@redhat.com> <51F7F422.2030607@redhat.com>
In-Reply-To: <51F7F422.2030607@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] usb: a problem of using libusb for usb pass through
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Linqiangmin <linqiangmin@huawei.com>, "Gonglei (Arei)" <arei.gonglei@huawei.com>, Luonengjun <luonengjun@huawei.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "Huangweidong (Hardware)" <huangweidong@huawei.com>

Hi,

On 07/30/2013 07:13 PM, Hans de Goede wrote:
> Hi,
>
> On 07/22/2013 02:58 PM, Gerd Hoffmann wrote:
>> On 07/16/13 10:45, Gonglei (Arei) wrote:
>>> Hi, Gerd
>>>     My Qemu version is 1.5.1, and use libusb for usb pass through.
>>>     I pass through a host usb device to the guest by bus number and physical port, when I unplug the usb device from
>>> the host, and plug in on the same physical port immediately, but the usb device don't show up in the guest.
>>>     The qemu log show:
>>> libusb_release_interface: -4 [NO_DEVICE]
>>> libusbx: error [_get_usbfs_fd] libusbx couldn't open USB device /dev/bus/usb/002/004: No such file or directory
>>> libusbx: error [_get_usbfs_fd] libusbx couldn't open USB device /dev/bus/usb/002/004: No such file or directory
>>> libusbx: error [_get_usbfs_fd] libusbx couldn't open USB device /dev/bus/usb/002/004: No such file or directory
>>>
>>>     I find the reason is that the global libusb_context has recorded the usb devices' devnum, but when the host device was unplugged and plugged
>>> from the host, the devnum will change, finally cause the problem.
>>>     Any ideas ? Thanks!
>>
>> Sounds like libusbx doesn't flush the cache on unplug even though it
>> should.  Hans?
>
> This looks like qemu's host-libusb code is re-using the libusb_device handle, what it should do after seeing an
> unplug (ie ENODEV error), it should close both the handle, and free any devices it may have, then redo
> the libusb_get_device_list() and you should get a libusb_device with the new address. This is what the
> usb code in the spice-client does, and it has no problems with sc

That should have read: "it has no problems with this scenario"

Regards,

Hans