From mboxrd@z Thu Jan  1 00:00:00 1970
From: Clemens Ladisch <clemens@ladisch.de>
Subject: Re: [PATCH - Preliminary support for Xonar Xense
 (resubmitAdded support for Xonar Xense. Only speaker out and mic in
 working.
Date: Tue, 30 Jul 2013 19:23:43 +0200
Message-ID: <51F7F69F.6040905@ladisch.de>
References: <1375119909-24454-1-git-send-email-madeallup.gen@gmail.com>
 <51F6C969.7050504@ladisch.de> <20130729212503.04107489@mainbox>
 <51F6D131.8040106@ladisch.de> <20130729214039.6d673367@mainbox>
 <51F75F01.6000607@ladisch.de> <51F7ECAB.7050504@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
In-Reply-To: <51F7ECAB.7050504@gmail.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Ian Dawes <madeallup.gen@gmail.com>
Cc: alsa-devel@alsa-project.org, patch@alsa-project.org
List-Id: alsa-devel@alsa-project.org

Ian Dawes wrote:
> On 30/07/13 07:36, Clemens Ladisch wrote:
>> Ian Dawes wrote:
>>> Clemens Ladisch <clemens@ladisch.de> wrote:
>>>> Ian Dawes wrote:
>>>>> Clemens Ladisch <clemens@ladisch.de> wrote:
>>>>>> Ian Dawes wrote:
>>>>>>> Signed-off-by: Ian Dawes <madeallup.gen@gmail.com>
>>>>>> The commit message was squashed into the subject line.  There's
>>>>>> probably an empty line missing between them.
>>>>> I'm not sure what this means.
>>>> Did you intend for the subject to be this long?
>>> Probably not. I added "resubmitted" to the subject
>> And the "Added support ..." was supposed to be in the subject, too?
>>
>>> How should I rectify this?
>> Ensure there is an empty line after the subject.
>
> Should I resubmit the patch then? (with the additional channels removed and fixed subject line)

Yes, please.


Regards,
Clemens