All of lore.kernel.org
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] getline prototype issue
Date: Tue, 30 Jul 2013 14:12:59 -0700	[thread overview]
Message-ID: <51F82C5B.3050402@freescale.com> (raw)

Simon,

Your patch

commit 669dfc2ed8d853d6bcdcafa1de6aca22929465e5
Author: Simon Glass <sjg@chromium.org>
Date:   Mon Mar 11 06:30:27 2013 +0000

    fdt: Ensure that libfdt_env.h comes from U-Boot

adds libfdt_env.h to HOSTCPPFLAGS. The causes a problem with one of our
older hosts. On the old hosts, getline prototype is protected by

#ifdef __USE_GNU

This should be OK if the C file has #define _GNU_SOURCE. However,
because of your patch, the stdio.h is included before _GNU_SOURCE is
defined. The result is warnings like this

aisimage.c: In function ?aisimage_generate?:
aisimage.c:313: warning: implicit declaration of function ?getline?
kwbimage.c: In function ?kwdimage_set_ext_header?:
kwbimage.c:236: warning: implicit declaration of function ?getline?
imximage.c: In function ?parse_cfg_file?:
imximage.c:430: warning: implicit declaration of function ?getline?
pblimage.c: In function ?pbl_parser?:
pblimage.c:137: warning: implicit declaration of function ?getline?
ublimage.c: In function ?parse_cfg_file?:
ublimage.c:179: warning: implicit declaration of function ?getline?

York

             reply	other threads:[~2013-07-30 21:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-30 21:12 York Sun [this message]
2013-07-30 21:17 ` [U-Boot] getline prototype issue Simon Glass
2013-07-30 21:29   ` York Sun
2013-07-30 21:38     ` York Sun
2013-07-30 21:47       ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F82C5B.3050402@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.