From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51430)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V4SRg-000236-Lk
	for qemu-devel@nongnu.org; Wed, 31 Jul 2013 05:11:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V4SRa-0006Hl-Fm
	for qemu-devel@nongnu.org; Wed, 31 Jul 2013 05:11:48 -0400
Received: from cantor2.suse.de ([195.135.220.15]:42030 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V4RNo-0008Ri-SQ
	for qemu-devel@nongnu.org; Wed, 31 Jul 2013 04:03:44 -0400
Message-ID: <51F8C4DC.2090302@suse.de>
Date: Wed, 31 Jul 2013 10:03:40 +0200
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <0e2ed0a9f48b8e6bbfbfa127e2e92c3d01b591fd.1375251985.git.minovotn@redhat.com>
	<87siyvns66.fsf@blackfin.pond.sub.org> <51F8B4BA.70209@redhat.com>
In-Reply-To: <51F8B4BA.70209@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v4] vl.c: Output error on invalid machine
 type provided
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michal Novotny <minovotn@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

Am 31.07.2013 08:54, schrieb Michal Novotny:
> there are
> still some code parts that are not using error_report() as well, e.g.
>=20
> fprintf(stderr, "Error: standard VGA not available\n");
>=20
> in the select_vgahw() function (line 2168) or:
>=20
>             fprintf(stderr, "Failed to start VNC server on `%s': %s\n",
>                     vnc_display, error_get_pretty(local_err));
>=20
> on line 4385 or:
>=20
> fprintf(stderr, "-incoming %s: %s\n", incoming,
> error_get_pretty(local_err));
>=20
> on line 4428 (I've been looking just to vl.c file so far).
>=20
> Shouldn't all this be using error_report() as well? If so, a follow-up
> patch would be nice.

See http://patchwork.ozlabs.org/patch/260801/ for a start. :)

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg