From mboxrd@z Thu Jan 1 00:00:00 1970 From: Li Zefan Subject: [PATCH 1/7] cgroup: fix a leak when percpu_ref_init() fails Date: Wed, 31 Jul 2013 16:16:28 +0800 Message-ID: <51F8C7DC.8060306@huawei.com> References: <51F8C7C5.9040608@huawei.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51F8C7C5.9040608@huawei.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Tejun Heo Cc: LKML , Cgroups ss->css_free() is not called when perfcpu_ref_init() fails. Signed-off-by: Li Zefan --- kernel/cgroup.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/cgroup.c b/kernel/cgroup.c index a64b7b8..e60eba2 100644 --- a/kernel/cgroup.c +++ b/kernel/cgroup.c @@ -4274,8 +4274,10 @@ static long cgroup_create(struct cgroup *parent, struct dentry *dentry, } err = percpu_ref_init(&css->refcnt, css_release); - if (err) + if (err) { + ss->css_free(cgrp); goto err_free_all; + } init_cgroup_css(css, ss, cgrp); } -- 1.8.0.2