From mboxrd@z Thu Jan  1 00:00:00 1970
From: Suravee Suthikulanit <suravee.suthikulpanit@amd.com>
Subject: Re: [PATCH 1/1 V4] x86/AMD: Fix nested svm crash due to
 assertion in __virt_to_maddr
Date: Wed, 31 Jul 2013 03:46:48 -0500
Message-ID: <51F8CEF8.4000408@amd.com>
References: <1374875167-2834-1-git-send-email-suravee.suthikulpanit@amd.com>
	<20130729104334.GA37169@ocelot.phlegethon.org>
	<51F6980C.2060201@amd.com> <51F773D3.2080705@amazon.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <51F773D3.2080705@amazon.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Egger, Christoph" <chegger@amazon.de>
Cc: Tim Deegan <tim@xen.org>, JBeulich@suse.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 7/30/2013 3:05 AM, Egger, Christoph wrote:
> On 29.07.13 18:27, Suravee Suthikulanit wrote:
>> On 7/29/2013 5:43 AM, Tim Deegan wrote:
>>> Hi,
>>>
>>> At 16:46 -0500 on 26 Jul (1374857167), suravee.suthikulpanit@amd.com
>>> wrote:
>>>> From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
>>>> +static struct page_info *
>>>> +_get_vmcb_page(struct domain *d, uint64_t vmcbaddr)
>>> Can you give this a name that makes it clearer that it's for nested
>>> VMCBs and not part of the handling of 'real' VMCBs?  Also, please drop
>>> the leading underscore.
>> What about "get_nvmcb_page"?
>>
> That's good. If you want to follow the naming scheme I suggest
> nsvm_get_nvmcb_page().
Thanks. I will rename to this.

Suravee
>
> Christoph
>
>