From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Joe Perches <joe@perches.com>,
LKML <linux-kernel@vger.kernel.org>, Borislav Petkov <bp@suse.de>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>,
Kees Cook <keescook@chromium.org>,
Tony Luck <tony.luck@intel.com>, Len Brown <lenb@kernel.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"Huang, Ying" <ying.huang@intel.com>
Subject: Re: [PATCH] APEI/ERST: Fix error message formatting
Date: Wed, 31 Jul 2013 15:27:09 +0530 [thread overview]
Message-ID: <51F8DF75.1030306@linux.vnet.ibm.com> (raw)
In-Reply-To: <20130729152230.GG6634@pd.tnic>
On 07/29/2013 08:52 PM, Borislav Petkov wrote:
> @@ -186,8 +186,8 @@ static int erst_exec_stall(struct apei_exec_context *ctx,
>
> if (ctx->value > FIRMWARE_MAX_STALL) {
> if (!in_nmi())
> - pr_warning(FW_WARN ERST_PFX
> - "Too long stall time for stall instruction: %llx.\n",
> + pr_warn(FW_WARN
> + "Too long stall time for stall instruction: 0x%llx.\n",
A minor nit: %#llx to stay consistent with the other changes later on.
> ctx->value);
> stall_time = FIRMWARE_MAX_STALL;
> } else
> @@ -206,8 +206,8 @@ static int erst_exec_stall_while_true(struct apei_exec_context *ctx,
>
> if (ctx->var1 > FIRMWARE_MAX_STALL) {
> if (!in_nmi())
> - pr_warning(FW_WARN ERST_PFX
> - "Too long stall time for stall while true instruction: %llx.\n",
> + pr_warn(FW_WARN
> + "Too long stall time for stall while true instruction: 0x%llx.\n",
Ditto.
Thanks,
Naveen
next prev parent reply other threads:[~2013-07-31 9:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 21:01 [PATCH] APEI/ERST: Fix error message formatting Borislav Petkov
2013-07-22 21:24 ` Kees Cook
2013-07-24 17:13 ` Naveen N. Rao
2013-07-24 17:23 ` Joe Perches
2013-07-25 11:23 ` Naveen N. Rao
2013-07-25 17:32 ` Bjorn Helgaas
2013-07-29 13:58 ` Borislav Petkov
2013-07-29 14:28 ` Bjorn Helgaas
2013-07-29 14:40 ` Borislav Petkov
2013-07-29 14:50 ` Bjorn Helgaas
2013-07-29 15:22 ` Borislav Petkov
2013-07-29 15:32 ` Joe Perches
2013-07-29 16:12 ` Bjorn Helgaas
2013-07-31 9:23 ` Borislav Petkov
2013-07-31 9:57 ` Naveen N. Rao [this message]
2013-07-31 9:46 ` Naveen N. Rao
2013-07-31 18:00 ` Bjorn Helgaas
2013-08-01 10:10 ` Naveen N. Rao
2013-07-24 18:10 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F8DF75.1030306@linux.vnet.ibm.com \
--to=naveen.n.rao@linux.vnet.ibm.com \
--cc=anton@enomsg.org \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=ccross@android.com \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=tony.luck@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.