All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: "gong.chen@linux.intel.com" <gong.chen@linux.intel.com>,
	"bp@suse.de" <bp@suse.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/mce: Pay no attention to 'F' bit in MCACOD when parsing 'UC' errors.
Date: Wed, 31 Jul 2013 15:36:37 +0530	[thread overview]
Message-ID: <51F8E1AD.4070708@linux.vnet.ibm.com> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F31C9F32B@ORSMSX106.amr.corp.intel.com>

On 07/25/2013 11:31 PM, Luck, Tony wrote:
> 	MCESEV(
> +		PANIC, "Action required but kernel thread is not continuable",
> +		SER, MASK(MCI_STATUS_OVER|MCI_UC_SAR|MCI_ADDR, MCI_UC_SAR|MCI_ADDR),
> +		MCGMASK(MCG_STATUS_RIPV|MCG_STATUS_EIPV, MCG_STATUS_RIPV|MCG_STATUS_EIPV),
> +		KERNEL
> +		),
> +	MCESEV(
>   		AR, "Action required: data load error in a user process",
>   		SER, MASK(MCI_STATUS_OVER|MCI_UC_SAR|MCI_ADDR|MCACOD, MCI_UC_SAR|MCI_ADDR|MCACOD_DATA),
>   		USER
>
> This just gives us a better panic message. Right?  Without this we'd keep walking the
> severity table until we hit the "Action required: unknown MCACOD" entry which will
> match and force a panic anyway.

Yes, that's correct. But I felt it would be good to have this entry to 
make it explicit.

>
> So I might look for better wording.  As far as the h/w is concerned the thread is continuable.
> Linux is just not smart enough (yet) to take the required recovery action.

Ok, how about: "Action required but unable to recover kernel thread"


Thanks,
Naveen


  reply	other threads:[~2013-07-31 10:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-23 20:34 [PATCH] x86/mce: Pay no attention to 'F' bit in MCACOD when parsing 'UC' errors Luck, Tony
2013-07-23 22:51 ` Tony Luck
2013-07-24  6:16   ` Chen Gong
2013-07-25 10:38     ` Naveen N. Rao
2013-07-25 18:01       ` Luck, Tony
2013-07-31 10:06         ` Naveen N. Rao [this message]
2013-07-24  6:19 ` Chen Gong
2013-07-24 15:55 ` Naveen N. Rao
2013-07-24 17:00   ` Luck, Tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F8E1AD.4070708@linux.vnet.ibm.com \
    --to=naveen.n.rao@linux.vnet.ibm.com \
    --cc=bp@suse.de \
    --cc=gong.chen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.