From: Srinivas KANDAGATLA <srinivas.kandagatla@st.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-kernel@vger.kernel.org, linus.walleij@linaro.org
Subject: Re: [PATCH 2/2] pinctrl: st: Staticize local symbols
Date: Wed, 31 Jul 2013 12:12:15 +0100 [thread overview]
Message-ID: <51F8F10F.4040403@st.com> (raw)
In-Reply-To: <1375071776-29037-2-git-send-email-sachin.kamat@linaro.org>
On 29/07/13 05:22, Sachin Kamat wrote:
> Symbols used only in this file are made static.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/pinctrl/pinctrl-st.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index 6246d7a..2a10a31 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -288,8 +288,8 @@ struct st_pinctrl {
>
> /* SOC specific data */
> /* STiH415 data */
> -unsigned int stih415_input_delays[] = {0, 500, 1000, 1500};
> -unsigned int stih415_output_delays[] = {0, 1000, 2000, 3000};
> +static unsigned int stih415_input_delays[] = {0, 500, 1000, 1500};
> +static unsigned int stih415_output_delays[] = {0, 1000, 2000, 3000};
>
> #define STIH415_PCTRL_COMMON_DATA \
> .rt_style = st_retime_style_packed, \
> @@ -324,7 +324,7 @@ static const struct st_pctl_data stih415_right_data = {
> };
>
> /* STiH416 data */
> -unsigned int stih416_delays[] = {0, 300, 500, 750, 1000, 1250, 1500,
> +static unsigned int stih416_delays[] = {0, 300, 500, 750, 1000, 1250, 1500,
> 1750, 2000, 2250, 2500, 2750, 3000, 3250 };
>
> static const struct st_pctl_data stih416_data = {
> @@ -811,7 +811,7 @@ static int st_pmx_get_funcs_count(struct pinctrl_dev *pctldev)
> return info->nfunctions;
> }
>
> -const char *st_pmx_get_fname(struct pinctrl_dev *pctldev,
> +static const char *st_pmx_get_fname(struct pinctrl_dev *pctldev,
> unsigned selector)
> {
> struct st_pinctrl *info = pinctrl_dev_get_drvdata(pctldev);
>
Acked-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
next prev parent reply other threads:[~2013-07-31 11:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 4:22 [PATCH 1/2] pinctrl: st: Convert to use devm_ioremap_resource Sachin Kamat
2013-07-29 4:22 ` [PATCH 2/2] pinctrl: st: Staticize local symbols Sachin Kamat
2013-07-31 11:12 ` Srinivas KANDAGATLA [this message]
2013-08-07 18:54 ` Linus Walleij
2013-07-31 11:11 ` [PATCH 1/2] pinctrl: st: Convert to use devm_ioremap_resource Srinivas KANDAGATLA
2013-08-07 18:52 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F8F10F.4040403@st.com \
--to=srinivas.kandagatla@st.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.