From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Wed, 31 Jul 2013 12:31:35 +0000
Subject: Re: [PATCH 1/2 v2] ARM: shmobile: r8a7778: add usb phy power control function
Message-Id: <51F903A7.5070206@cogentembedded.com>
List-Id: <linux-sh.vger.kernel.org>
References: <87r4efb6al.wl%kuninori.morimoto.gx@renesas.com>
In-Reply-To: <87r4efb6al.wl%kuninori.morimoto.gx@renesas.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: linux-sh@vger.kernel.org

Hello.

On 31-07-2013 10:19, Kuninori Morimoto wrote:

> USB phy initialisation function is needed from not only
> USB Host but also USB Function too.
> This patch adds usb phy common control function.

> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
[...]

> diff --git a/arch/arm/mach-shmobile/setup-r8a7778.c b/arch/arm/mach-shmobile/setup-r8a7778.c
> index 1a154d4..b65044a 100644
> --- a/arch/arm/mach-shmobile/setup-r8a7778.c
> +++ b/arch/arm/mach-shmobile/setup-r8a7778.c
> @@ -95,29 +95,46 @@ static struct sh_timer_config sh_tmu1_platform_data __initdata = {
>   		&sh_tmu##idx##_platform_data,		\
>   		sizeof(sh_tmu##idx##_platform_data))
>
> -/* USB */
> -static struct usb_phy *phy;
> +int r8a7778_usb_phy_power(bool enable)
> +{
> +	static struct usb_phy *phy = NULL;
> +	int ret = 0;
> +
> +	if (!phy)
> +		phy = usb_get_phy(USB_PHY_TYPE_USB2);
> +

    Don't think this blank line is needed.

> +	if (IS_ERR(phy)) {
> +		pr_err("it doesn't have usb phy driver\n");

    What "it"? "Kernel" maybe? And please capitalize "USB PHY".

WBR, Sergei