Re: [PATCH] Change the implementation of action_on_fail

[Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

On 07/31/2013 04:29 PM, Vivek Goyal wrote:
> On Wed, Jul 31, 2013 at 04:25:57PM +0200, Harald Hoyer wrote:
> 
> [..]
>>>> I like it.
>>>>
>>>> Vivek: would that solve one of your systemd problems?
>>>
>>> Hi Harald,
>>>
>>> Yes this should solve one of the problems of being able to call emergency
>>> shell from kdump module.
>>>
>>> I was thinking of modirying emergency.service on the fly and then reload
>>> systemd config. But I guess this solution is simpler.
>>>
>>> It also takes away the flexibility of being able to specify "reboot" or
>>> some other actions as failure actions. But nobody as asked for those
>>> yet.
>>>
>>> So yes, agreed, this will solve atleast one problem. So makes sense
>>> to take it in.
>>>
>>> Thanks
>>> Vivek
>>>
>>
>> pushed, thanks!
> 
> Hi Harald,
> 
> Do you still like the parameter name "rd.action_on_fail". I think a new
> parameter say, "rd.no_emergecny_shell" might make more sense to reflect
> what we are doing.
> 
> If you like it, I can request bao to post a new patch and make appropriate
> changes.
> 
> Thanks
> Vivek
> 

You can add the rd.no_emergency_shell parser in your kdump module and touch the
marker file. I think that gives you more flexibility for runtime decisions.
You can just add and remove that file on will.