From: Stephen Warren <swarren@wwwdotorg.org>
To: Nishanth Menon <nm@ti.com>
Cc: Bill Huang <bilhuang@nvidia.com>,
sameo@linux.intel.com, rob.herring@calxeda.com,
pawel.moll@arm.com, mark.rutland@arm.com,
ian.campbell@citrix.com, rob@landley.net, lee.jones@linaro.org,
broonie@linaro.org, j-keerthy@ti.com, grant.likely@linaro.org,
ian@slimlogic.co.uk, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Mallikarjun Kasoju <mkasoju@nvidia.com>
Subject: Re: [PATCH v2 1/1] mfd: palmas: Add power off control
Date: Wed, 31 Jul 2013 11:20:04 -0600 [thread overview]
Message-ID: <51F94744.40301@wwwdotorg.org> (raw)
In-Reply-To: <51F8FBC4.1040009@ti.com>
On 07/31/2013 05:57 AM, Nishanth Menon wrote:
> On 07/31/2013 02:17 AM, Bill Huang wrote:
>> Hook up "pm_power_off" to palmas power off routine if there is DT
>> property "ti,system-power-controller" defined, so platform which is
>> powered by this regulator can be powered off properly.
>>
>> Based on work by:
>> Mallikarjun Kasoju <mkasoju@nvidia.com>
>>
>> Signed-off-by: Bill Huang <bilhuang@nvidia.com>
>> cc: Mallikarjun Kasoju <mkasoju@nvidia.com>
>> ---
>> .../devicetree/bindings/regulator/palmas-pmic.txt | 5 +++
>> drivers/mfd/palmas.c | 33
>> ++++++++++++++++++--
>
> Since the specific question on v1 was not answered, I will ask again,
> any reason why it wont fit in drivers/power/reset/ is'nt it the right
> place to add this?
I think it makes sense to put simple standalone reset drivers into
drivers/power/reset. However, where reset is just one tiny function of a
larger device that already has a driver, it's fine for one driver to
implement multiple features or essentially expose multiple subsystems.
(besides this is system power off not system reset; which is
drivers/power/reset?)
next prev parent reply other threads:[~2013-07-31 17:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 7:17 [PATCH v2 1/1] mfd: palmas: Add power off control Bill Huang
2013-07-31 7:17 ` Bill Huang
2013-07-31 11:57 ` Nishanth Menon
2013-07-31 11:57 ` Nishanth Menon
2013-07-31 17:20 ` Stephen Warren [this message]
2013-07-31 18:31 ` Nishanth Menon
2013-07-31 18:31 ` Nishanth Menon
2013-08-01 11:08 ` Bill Huang
2013-08-01 13:08 ` Nishanth Menon
2013-08-02 5:45 ` Bill Huang
2013-08-02 14:39 ` Nishanth Menon
2013-08-05 10:32 ` Bill Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F94744.40301@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=bilhuang@nvidia.com \
--cc=broonie@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=ian@slimlogic.co.uk \
--cc=j-keerthy@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mkasoju@nvidia.com \
--cc=nm@ti.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.