All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Seiler <christian@iwakd.de>
To: Peter Rajnoha <prajnoha@redhat.com>
Cc: LVM general discussion and development <linux-lvm@redhat.com>
Subject: Re: [linux-lvm] [PATCH] lvremove: perform retry logic also on -real subvolume for snapshots
Date: Wed, 31 Jul 2013 19:27:45 +0200	[thread overview]
Message-ID: <51F94911.8080405@iwakd.de> (raw)
In-Reply-To: <51F8FEB7.9050004@redhat.com>

Hi there,

> One more question - what's the distro you're using? Some distros
> change udev rules or they add completely different ones from upstream
> (for example I know that Debian changes upstream LVM udev rules).

The computer in question is running Debian Squeeze (oldstable) (where
the LVM version was the one that was too old; a system upgrade to Wheezy
is planned but will take a while) and then I compiled the LVM version
that comes with Wheezy (stable) where at least from what I gathered from
the commit mailing archives here both fixes I mentioned in the original
mail are included.

FYI: These are the LVM udev rools that are in the LVM2 package that's
currently installed.

------------------------------------------------------------------
cat /lib/udev/rules.d/56-lvm.rules
# Udev rules for LVM.
# See /usr/share/doc/lvm2/README.udev for further information.

ACTION!="add|change", GOTO="lvm_end"
ENV{DM_UDEV_RULES}=="", GOTO="lvm_end"
ENV{DM_UUID}!="LVM-?*", GOTO="lvm_end"

# Use DM name and split it up into its VG/LV/layer constituents.
IMPORT{program}="/sbin/dmsetup splitname --nameprefixes --noheadings
--rows $env{DM_NAME}"

ENV{DM_UDEV_DISABLE_SUBSYSTEM_RULES_FLAG}!="1", GOTO="lvm_end"

ENV{DM_UDEV_DISABLE_DISK_RULES_FLAG}="1"
ENV{DM_UDEV_DISABLE_OTHER_RULES_FLAG}="1"
OPTIONS:="nowatch"

LABEL="lvm_end"

cat /lib/udev/rules.d/60-persistent-storage-lvm.rules
# Udev rules for LVM.
# See /usr/share/doc/lvm2/README.udev for further information.

ACTION!="add|change", GOTO="persistent_storage_lvm_end"
ENV{DM_UDEV_RULES}=="", GOTO="persistent_storage_lvm_end"
ENV{DM_UUID}!="LVM-?*", GOTO="persistent_storage_lvm_end"

ENV{DM_UDEV_DISABLE_SUBSYSTEM_RULES_FLAG}=="1",
GOTO="persistent_storage_lvm_end"

ENV{DM_VG_NAME}=="?*", ENV{DM_LV_NAME}=="?*", ENV{DM_LV_LAYER}=="",
SYMLINK+="$env{DM_VG_NAME}/$env{DM_LV_NAME}"

LABEL="persistent_storage_lvm_end"
------------------------------------------------------------------

> Or have you tested this with upstream (or Fedora) LVM version?

I will do so once I get the chance. But since it is very likely that the
specific environment here might also contribute to the likelyhood of the
failures occuring, I'll do so not by trying it on a clean Fedora install
but by compiling the current upstream git on the Debian computer in
question.

Christian

  reply	other threads:[~2013-07-31 17:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-30 15:18 [linux-lvm] [PATCH] lvremove: perform retry logic also on -real subvolume for snapshots Christian Seiler
2013-07-31  8:50 ` Peter Rajnoha
2013-07-31 11:31   ` Christian Seiler
2013-07-31 12:10     ` Peter Rajnoha
2013-07-31 17:27       ` Christian Seiler [this message]
2013-08-01  9:19         ` Christian Seiler
2013-08-01 10:16           ` Zdenek Kabelac
2013-08-01 10:53             ` Christian Seiler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F94911.8080405@iwakd.de \
    --to=christian@iwakd.de \
    --cc=linux-lvm@redhat.com \
    --cc=prajnoha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.