All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Hervé Poussineau" <hpoussin@reactos.org>
To: "Andreas Färber" <andreas.faerber@web.de>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] i82378: cleanup implementation
Date: Wed, 31 Jul 2013 20:58:37 +0200	[thread overview]
Message-ID: <51F95E5D.7050503@reactos.org> (raw)
In-Reply-To: <51F9482F.1030207@web.de>

Andreas Färber a écrit :
> Am 23.07.2013 23:16, schrieb Hervé Poussineau:
>> diff --git a/hw/isa/i82378.c b/hw/isa/i82378.c
>> index de71d81..f2045de 100644
>> --- a/hw/isa/i82378.c
>> +++ b/hw/isa/i82378.c
> [...]
>> -static const VMStateDescription vmstate_pci_i82378 = {
>> -    .name = "pci-i82378",
>> +static const VMStateDescription vmstate_i82378 = {
>> +    .name = "i82378",
>>      .version_id = 0,
>>      .minimum_version_id = 0,
>>      .fields = (VMStateField[]) {
>> -        VMSTATE_PCI_DEVICE(pci_dev, PCIi82378State),
>> +        VMSTATE_PCI_DEVICE(parent_obj, I82378State),
>>          VMSTATE_END_OF_LIST()
>>      },
>>  };
> [snip]
> 
> Renaming the section would break backwards compatibility, we'll need to
> live with that name.

Not a problem.
Or, you can update version_id and minimum_version_id to 1, and ignore 
backward compatibility problems, as i82378 is only used in PPC machine 
by default.
Do as you want.

Hervé

      reply	other threads:[~2013-07-31 18:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-23 21:16 [Qemu-devel] [PATCH 0/2] prep/i82378: simplify and enhance i82378 chipset implementation Hervé Poussineau
2013-07-23 21:16 ` [Qemu-devel] [PATCH 1/2] prep_pci: set isa_mem_base in the PCI host bridge Hervé Poussineau
2013-07-23 22:33   ` Andreas Färber
2013-07-24  5:37     ` Hervé Poussineau
2013-07-23 21:16 ` [Qemu-devel] [PATCH 2/2] i82378: cleanup implementation Hervé Poussineau
2013-07-29 21:53   ` Andreas Färber
2013-07-30 20:06     ` Hervé Poussineau
2013-07-31 17:06       ` Andreas Färber
2013-07-31 17:23   ` Andreas Färber
2013-07-31 18:58     ` Hervé Poussineau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F95E5D.7050503@reactos.org \
    --to=hpoussin@reactos.org \
    --cc=andreas.faerber@web.de \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.