From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Vadim A. Misbakh-Soloviov" Subject: Re: [Patch V3 3/3] Fixed policy Makefile with Ian Campbell advice: Date: Wed, 31 Jul 2013 23:29:37 +0400 Message-ID: <51F965A1.7090107@mva.name> References: <1375187680-7584-1-git-send-email-mva@mva.name> <1375187680-7584-3-git-send-email-mva@mva.name> <1375190173.32691.6.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4745462341135441927==" Return-path: In-Reply-To: <1375190173.32691.6.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============4745462341135441927== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="HDJBXs8IbAA18dAilC1ibhnBUuuMaSwem" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HDJBXs8IbAA18dAilC1ibhnBUuuMaSwem Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Nice, that both of you agreed with patchset. But unfortunately I'm a newbie in Xen development, so I don't know, what should I do now. Just wait when someone commit it into staging? Or I should push it somewhere? = :) 30.07.2013 17:16, Ian Campbell =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > On Tue, 2013-07-30 at 16:34 +0400, Vadim A. Misbakh-Soloviov wrote: >> From: "Vadim A. Misbakh-Soloviov" >> >> 30.07.2013 13:51, Ian Campbell wrote: >>> I think it would be a bit less surprising for drive by patchers etc t= o >>> remove the DESTDIR from POLICY_LOADPATH and add it to the install >>> target, which is the usual way to do things. Up to you/Vadim though. >> >> Signed-off-by: Vadim A. Misbakh-Soloviov >=20 > Looks good to me, I'll give Daniel a chance to object though. >=20 > Ian. >=20 >> --- >> tools/flask/policy/Makefile | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/tools/flask/policy/Makefile b/tools/flask/policy/Makefile= >> index df1e8f3..a1c0f11 100644 >> --- a/tools/flask/policy/Makefile >> +++ b/tools/flask/policy/Makefile >> @@ -33,7 +33,7 @@ M4 ?=3D m4 >> OUTPUT_POLICY =3D 24 >> =20 >> POLICY_FILENAME =3D xenpolicy.$(OUTPUT_POLICY) >> -POLICY_LOADPATH =3D $(DESTDIR)/boot >> +POLICY_LOADPATH =3D /boot >> =20 >> # policy source layout >> POLDIR :=3D policy >> @@ -103,8 +103,8 @@ POLICY_SECTIONS +=3D $(USERS) $(CONSTRAINTS) $(ISI= D_DEFS) >> all: $(POLICY_FILENAME) >> =20 >> install: $(POLICY_FILENAME) >> - $(INSTALL_DIR) $(POLICY_LOADPATH) >> - $(INSTALL_DATA) $^ $(POLICY_LOADPATH) >> + $(INSTALL_DIR) $(DESTDIR)/$(POLICY_LOADPATH) >> + $(INSTALL_DATA) $^ $(DESTDIR)/$(POLICY_LOADPATH) >> =20 >> $(POLICY_FILENAME): policy.conf >> $(CHECKPOLICY) $(CHECKPOLICY_PARAM) $^ -o $@ >=20 >=20 >=20 > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel >=20 --HDJBXs8IbAA18dAilC1ibhnBUuuMaSwem Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJR+WWhAAoJECZQPTSbOzNL0doP/2NS81dfWRcFIVIZwfwpu1c5 HtGEgNqJgEXg8Ivqs3MtCehF5i6rDf3JDMkGV3IxlGHBSsHg2IB6RKEKVG9DSNGh EzfwyJW6RI1uWJifQ+kO8T/kUyfrbkj8lIT3Eg9oYyqjxxMNAC4/FMUjgLZVDtjV qjoZjd1RjCg9ZLPTRc+p/irdBPULBfp7sK1WP2xOU+V5cwyvAFBusQQrNzTGtwYR H+uoDMJHjULiBlgsY+YwYMo9JDYuc//tnSNJ8c7KUDeihR7JU3QkH4aTfTUTmCg2 ZDFwdjZccJ/PyI1Xp4wp41mkzA3o1HZtNFXNGZTxjtbiuimk5Oz22+tY2hVdVU6w Gq7VzbA54nmKvM99CkLJyWYVrrWXuTycrJY7OhhEJrhyYOT9/TKm2yNLTBIQxaEV nZ4Qk9OI59s2w8rGAeOpAXA3FB03pnwlXBHs3XpEZXVsbLTtPpoVlS4ylqa/m/Re uAmaOIzxR2mQZ4pWpdncoXQti6Q6+T+Zzw12UqbcXoLhdCKXKsWTWOfXQcHnZEjO rQjEfhhvOfBXWnsuXGbsjCIG+uSTrNTgS4W+pF7HIwqGHyZLXP4YcfYKz85YhOLD Uc1ZaKQT0wqiCtITB6yA5/vmMuKKhArdV1rkCKq4d8tXPVUmK598aYyOpzEg7yrj diNjh//Rh1csu27K8rOW =vcw9 -----END PGP SIGNATURE----- --HDJBXs8IbAA18dAilC1ibhnBUuuMaSwem-- --===============4745462341135441927== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============4745462341135441927==--