From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Ferreri Tonello Subject: Re: [PATCH 1/4] ALSA: Added jack detection kcontrol support Date: Wed, 31 Jul 2013 20:49:25 -0700 Message-ID: <51F9DAC5.2000106@felipetonello.com> References: <1374863133-6745-1-git-send-email-eu@felipetonello.com> <1374863133-6745-2-git-send-email-eu@felipetonello.com> <20130726185458.GX9858@sirena.org.uk> <20130726224813.GB9858@sirena.org.uk> <20130727122524.GH9858@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Takashi Iwai Cc: Mark Brown , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, David Henningsson , Wang Xingchao , Jaroslav Kysela List-Id: alsa-devel@alsa-project.org Hi Takashi, On 07/29/2013 05:05 AM, Takashi Iwai wrote: > At Sat, 27 Jul 2013 13:25:24 +0100, > Mark Brown wrote: >> >> On Fri, Jul 26, 2013 at 04:13:40PM -0700, Felipe Tonello wrote: >>> On Fri, Jul 26, 2013 at 3:48 PM, Mark Brown wrote: >> >>>>>> What I'd expect to happen here is that for multi function jacks we >>>>>> create a control per function if the controls are valid. >> >>> Ok, so the idea is just to change the control to type integer instead >>> of boolean, right? >>> Because as you say, the user will be able to check the type of jack >>> based on the status value, right? >> >> It might be more idiomatic and more compatible with userspace to create >> multiple controls for the jack, there was some discussion of this in the >> past I think but I can't remember the result. > > I also forget the end result :) > > Another option would be to make an enum control, but multiple boolean > controls are easier in the end. The headset controls of HD-audio are > represented in that way, too (because HD-audio specification can't > tell better). Yes. Thanks for the comment. Felipe Tonello