Re: [Qemu-devel] [PATCH] cpus: use cpu_is_stopped efficiently

["\"“tiejun.chen”\"" <tiejun.chen@windriver.com>]

On 07/26/2013 04:47 PM, Tiejun Chen wrote:
> It makes more sense and simple later.

Any feedback :)

Tiejun

>
> Signed-off-by: Tiejun Chen <tiejun.chen@windriver.com>
> ---
>   cpus.c |   14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/cpus.c b/cpus.c
> index c232265..a997632 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -62,6 +62,11 @@
>
>   static CPUArchState *next_cpu;
>
> +bool cpu_is_stopped(CPUState *cpu)
> +{
> +    return !runstate_is_running() || cpu->stopped;
> +}
> +
>   static bool cpu_thread_is_idle(CPUArchState *env)
>   {
>       CPUState *cpu = ENV_GET_CPU(env);
> @@ -69,7 +74,7 @@ static bool cpu_thread_is_idle(CPUArchState *env)
>       if (cpu->stop || cpu->queued_work_first) {
>           return false;
>       }
> -    if (cpu->stopped || !runstate_is_running()) {
> +    if (cpu_is_stopped(cpu)) {
>           return true;
>       }
>       if (!cpu->halted || qemu_cpu_has_work(cpu) ||
> @@ -432,11 +437,6 @@ void cpu_synchronize_all_post_init(void)
>       }
>   }
>
> -bool cpu_is_stopped(CPUState *cpu)
> -{
> -    return !runstate_is_running() || cpu->stopped;
> -}
> -
>   static void do_vm_stop(RunState state)
>   {
>       if (runstate_is_running()) {
> @@ -455,7 +455,7 @@ static bool cpu_can_run(CPUState *cpu)
>       if (cpu->stop) {
>           return false;
>       }
> -    if (cpu->stopped || !runstate_is_running()) {
> +    if (cpu_is_stopped(cpu)) {
>           return false;
>       }
>       return true;
>