All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: <xen-devel@lists.xen.org>, <linux-kernel@vger.kernel.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH 1/3] xen-gnt: prevent adding duplicate gnt callbacks
Date: Thu, 1 Aug 2013 11:12:38 +0100	[thread overview]
Message-ID: <51FA3496.6020803@citrix.com> (raw)
In-Reply-To: <1375282844-4314-2-git-send-email-roger.pau@citrix.com>

On 31/07/13 16:00, Roger Pau Monne wrote:
> With the current implementation, the callback in the tail of the list
> can be added twice, because the check done in
> gnttab_request_free_callback is bogus, callback->next can be NULL if
> it is the last callback in the list. If we add the same callback twice
> we end up with an infinite loop, were callback == callback->next.
> 
> Replace this check with a proper one that iterates over the list to
> see if the callback has already been added.

As a minimal fix suitable for stable,

Reviewed-by: David Vrabel <david.vrabel@citrix.com>

David

  parent reply	other threads:[~2013-08-01 10:12 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-31 15:00 [PATCH 0/3] xen: fixes for gnt and block Roger Pau Monne
2013-07-31 15:00 ` [PATCH 1/3] xen-gnt: prevent adding duplicate gnt callbacks Roger Pau Monne
2013-07-31 18:33   ` Matt Wilson
2013-07-31 18:33   ` Matt Wilson
2013-08-01 10:12   ` David Vrabel [this message]
2013-08-01 10:12   ` David Vrabel
2013-07-31 15:00 ` Roger Pau Monne
2013-07-31 15:00 ` [PATCH 2/3] xen-blkfront: improve aproximation of required grants per request Roger Pau Monne
2013-07-31 15:00 ` Roger Pau Monne
2013-08-01 10:10   ` David Vrabel
2013-08-01 10:10   ` [Xen-devel] " David Vrabel
2013-07-31 15:00 ` [PATCH 3/3] xen-blkfront: revoke foreign access for grants not mapped by the backend Roger Pau Monne
2013-07-31 15:00 ` Roger Pau Monne
2013-08-01  6:35   ` Matt Wilson
2013-08-01  6:35   ` Matt Wilson
2013-08-01 10:10   ` [Xen-devel] " David Vrabel
2013-08-09 15:08     ` Konrad Rzeszutek Wilk
2013-08-09 15:08     ` [Xen-devel] " Konrad Rzeszutek Wilk
2013-08-12 10:58       ` Roger Pau Monné
2013-08-12 12:02         ` Konrad Rzeszutek Wilk
2013-08-12 12:02         ` [Xen-devel] " Konrad Rzeszutek Wilk
2013-08-12 10:58       ` Roger Pau Monné
2013-08-01 10:10   ` David Vrabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51FA3496.6020803@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.