All of lore.kernel.org
 help / color / mirror / Atom feed
From: b.brezillon@overkiz.com (boris brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/8] ARM: at91/dt: make use of periph id macros
Date: Thu, 01 Aug 2013 13:06:20 +0200	[thread overview]
Message-ID: <51FA412C.9080900@overkiz.com> (raw)
In-Reply-To: <CACQ1gAjQ4raVHbMUfPZM=BQ-+SCbOJvxmR_5Vh=xpX592MZo7A@mail.gmail.com>

Hello Richard,

On 01/08/2013 11:27, Richard Genoud wrote:
> 2013/8/1 Richard Genoud <richard.genoud@gmail.com>:
>> 2013/8/1 Boris BREZILLON <b.brezillon@overkiz.com>:
>>> Hello,
>>>
>>> This patch series move at91 SoCs peripheral id definitions from machine
>>> specific include dir to dt-bindings include dir.
>>> These macros are used to reference interrupts instead of peripheral numbers.
>>>
>>> This makes dt definitions cleaner and easier to debug (one can easily tell if
>>> the peripheral macro used to reference an interrupt line is not the good one).
>>>
>>> These macros will be used for clk definitions and references too.
>>>
>>> I am not sure 'include/dt-bindings/at91/xxx' is the best place to put these
>>> definitions as there are no soc specific directories in dt-bindings include
>>> dir right now. Maybe something like 'include/dt-bindings/soc/at91/xxx' or
>>> 'include/dt-bindings/peripherals/at91/xxx' would be better.
>>> What do you think ?
>> Well, I'd rather use "atmel" than "at91" because, AFAIK, this prefix
>> has been dropped for new atmel SoCs (sama5 for instance).

Sure, I will replace at91 by atmel, but I'd like to get some feedback 
from at91
maintainers before doing this.

Could devicetree maintainers take a look at this series too ?
I don't want to mess with dt-bindings include directory by adding some 
files at
the wrong place...

> [changed Mark Brown address from opensource.wolfsonmicro.com to
> kernel.org (the 1st one failed)]

Sorry Mark. Do you want me to resend you the whole series ?

>
> The whole serie seems good to me (add adding the missing defines is great).
>
> You can add my:
> Reviewed-by: Richard Genoud <richard.genoud@gmail.com>
> on the whole serie.
>
> and my
> Tested-by: Richard Genoud <richard.genoud@gmail.com>
> on patch 7/8
>
>
> Richard.

Thanks for the review and the tests.

Best Regards,

Boris

WARNING: multiple messages have this Message-ID (diff)
From: boris brezillon <b.brezillon@overkiz.com>
To: Richard Genoud <richard.genoud@gmail.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	Ludovic Desroches <ludovic.desroches@atmel.com>,
	Russell King <linux@arm.linux.org.uk>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 0/8] ARM: at91/dt: make use of periph id macros
Date: Thu, 01 Aug 2013 13:06:20 +0200	[thread overview]
Message-ID: <51FA412C.9080900@overkiz.com> (raw)
In-Reply-To: <CACQ1gAjQ4raVHbMUfPZM=BQ-+SCbOJvxmR_5Vh=xpX592MZo7A@mail.gmail.com>

Hello Richard,

On 01/08/2013 11:27, Richard Genoud wrote:
> 2013/8/1 Richard Genoud <richard.genoud@gmail.com>:
>> 2013/8/1 Boris BREZILLON <b.brezillon@overkiz.com>:
>>> Hello,
>>>
>>> This patch series move at91 SoCs peripheral id definitions from machine
>>> specific include dir to dt-bindings include dir.
>>> These macros are used to reference interrupts instead of peripheral numbers.
>>>
>>> This makes dt definitions cleaner and easier to debug (one can easily tell if
>>> the peripheral macro used to reference an interrupt line is not the good one).
>>>
>>> These macros will be used for clk definitions and references too.
>>>
>>> I am not sure 'include/dt-bindings/at91/xxx' is the best place to put these
>>> definitions as there are no soc specific directories in dt-bindings include
>>> dir right now. Maybe something like 'include/dt-bindings/soc/at91/xxx' or
>>> 'include/dt-bindings/peripherals/at91/xxx' would be better.
>>> What do you think ?
>> Well, I'd rather use "atmel" than "at91" because, AFAIK, this prefix
>> has been dropped for new atmel SoCs (sama5 for instance).

Sure, I will replace at91 by atmel, but I'd like to get some feedback 
from at91
maintainers before doing this.

Could devicetree maintainers take a look at this series too ?
I don't want to mess with dt-bindings include directory by adding some 
files at
the wrong place...

> [changed Mark Brown address from opensource.wolfsonmicro.com to
> kernel.org (the 1st one failed)]

Sorry Mark. Do you want me to resend you the whole series ?

>
> The whole serie seems good to me (add adding the missing defines is great).
>
> You can add my:
> Reviewed-by: Richard Genoud <richard.genoud@gmail.com>
> on the whole serie.
>
> and my
> Tested-by: Richard Genoud <richard.genoud@gmail.com>
> on patch 7/8
>
>
> Richard.

Thanks for the review and the tests.

Best Regards,

Boris

  reply	other threads:[~2013-08-01 11:06 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-01  6:48 [PATCH 0/8] ARM: at91/dt: make use of periph id macros Boris BREZILLON
2013-08-01  6:48 ` Boris BREZILLON
2013-08-01  6:52 ` [PATCH 1/8] ARM: at91: move peripheral id definitions to dt-bindings include dir Boris BREZILLON
2013-08-01  6:52   ` Boris BREZILLON
2013-08-07 20:24   ` Arnd Bergmann
2013-08-07 20:24     ` Arnd Bergmann
2013-08-08  4:09     ` boris brezillon
2013-08-08  4:09       ` boris brezillon
2013-08-19 16:46       ` Nicolas Ferre
2013-08-19 16:46         ` Nicolas Ferre
2013-08-20  6:11         ` b.brezillon at overkiz.com
2013-08-20  6:11           ` b.brezillon
2013-08-20  9:21         ` Richard Genoud
2013-08-20  9:21           ` Richard Genoud
2013-08-01  6:53 ` [PATCH 2/8] ARM: at91/dt: use periph id macros for at91rm9200 interrupt definitions Boris BREZILLON
2013-08-01  6:53   ` Boris BREZILLON
2013-08-01  6:54 ` [PATCH 3/8] ARM: at91/dt: use periph id macros for at91sam9260 " Boris BREZILLON
2013-08-01  6:54   ` Boris BREZILLON
2013-08-01  6:55 ` [PATCH 4/8] ARM: at91/dt: use periph id macros for at91sam9263 " Boris BREZILLON
2013-08-01  6:55   ` Boris BREZILLON
2013-08-01  6:57 ` [PATCH 5/8] ARM: at91/dt: use periph id macros for at91sam9g45 " Boris BREZILLON
2013-08-01  6:57   ` Boris BREZILLON
2013-08-01  6:58 ` [PATCH 6/8] ARM: at91/dt: use periph id macros for at91sam9n12 " Boris BREZILLON
2013-08-01  6:58   ` Boris BREZILLON
2013-08-01  7:00 ` [PATCH 7/8] ARM: at91/dt: use periph id macros for at91sam9x5 " Boris BREZILLON
2013-08-01  7:00   ` Boris BREZILLON
2013-08-01  7:01 ` [PATCH 8/8] ARM: at91/dt: use periph id macros for sama5d3 " Boris BREZILLON
2013-08-01  7:01   ` Boris BREZILLON
2013-08-01  7:37 ` [PATCH 0/8] ARM: at91/dt: make use of periph id macros Richard Genoud
2013-08-01  7:37   ` Richard Genoud
2013-08-01  9:27   ` Richard Genoud
2013-08-01  9:27     ` Richard Genoud
2013-08-01 11:06     ` boris brezillon [this message]
2013-08-01 11:06       ` boris brezillon
2013-08-01 11:13       ` Mark Brown
2013-08-01 11:13         ` Mark Brown
2013-08-01 11:20         ` boris brezillon
2013-08-01 11:20           ` boris brezillon
2013-08-02  9:04   ` boris brezillon
2013-08-02  9:04     ` boris brezillon
2013-08-02  9:28     ` Richard Genoud
2013-08-02  9:28       ` Richard Genoud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51FA412C.9080900@overkiz.com \
    --to=b.brezillon@overkiz.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.