From: Lars-Peter Clausen <lars@metafoo.de>
To: bardliao@realtek.com
Cc: oder_chiou@realtek.com, alsa-devel@alsa-project.org,
swarren@nvidia.com, swarren@wwwdotorg.org, lgirdwood@gmail.com,
broonie@kernel.org, flove@realtek.com
Subject: Re: [PATCH] ASoC: rt5640: remove unused mux
Date: Thu, 01 Aug 2013 14:04:47 +0200 [thread overview]
Message-ID: <51FA4EDF.4020809@metafoo.de> (raw)
In-Reply-To: <1375356562-28151-1-git-send-email-bardliao@realtek.com>
On 08/01/2013 01:29 PM, bardliao@realtek.com wrote:
> From: Bard Liao <bardliao@realtek.com>
>
> Remove unused "INL Mux" and "INR Mux".
>
> Signed-off-by: Bard Liao <bardliao@realtek.com>
> ---
> I meet a kernel panic issue if I don't remove the unused widget and modify something in rt5640_dapm_widgets[] and/or rt5640_dapm_routes[].
> The message is "Unable to handle kernel paging request at virtual address 6b6b6bd3".
> PC is at dapm_clear_walk_output+0x18/0x7c
> LR is at dapm_clear_walk_output+0x18/0x7c
> If I remove those unused widget, ie. not appear in rt5640_dapm_routes[], everything is fine.
> So I think they should be removed.
The kernel panic is my fault. I introduced a memory corruption bug in the
ASoC DAPM core. It's not specific to this drivers, I'll send the fix in a
minute.
- Lars
next prev parent reply other threads:[~2013-08-01 12:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 11:29 [PATCH] ASoC: rt5640: remove unused mux bardliao
2013-08-01 12:04 ` Lars-Peter Clausen [this message]
2013-08-01 12:22 ` Bard Liao
2013-08-01 13:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FA4EDF.4020809@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=broonie@kernel.org \
--cc=flove@realtek.com \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.