From: Mark Tinguely <tinguely@sgi.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: "'linux-xfs@oss.sgi.com'" <linux-xfs@oss.sgi.com>
Subject: Re: [PATCH] xfsprogs: fix unint var in repair phase6
Date: Thu, 01 Aug 2013 09:50:38 -0500 [thread overview]
Message-ID: <51FA75BE.9080705@sgi.com> (raw)
In-Reply-To: <51F9B626.4010707@redhat.com>
On 07/31/13 20:13, Eric Sandeen wrote:
> 2 calls to libxfs_bmapi_write exist in repair's phase6
> where "first" is uninitialized, but is accessed
> in that function.
>
> Normally we call xfs_bmap_init() first to initialize
> both the free list and the first block, but in these
> cases, the free list var is sent as NULL.
>
> So in these 2 cases, explicitly initialize the "first"
> variable to NULLFSBLOCK as xfs_bmap_init() does
> elsewhere.
>
> Coverity caught this.
>
> Signed-off-by: Eric Sandeen<sandeen@redhat.com>
> ---
Looks good.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-08-01 14:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 1:13 [PATCH] xfsprogs: fix unint var in repair phase6 Eric Sandeen
2013-08-01 14:50 ` Mark Tinguely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FA75BE.9080705@sgi.com \
--to=tinguely@sgi.com \
--cc=linux-xfs@oss.sgi.com \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.