From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>
Cc: Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
amartin-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH tegra-cbootimage] Add automake option subdir-objects to prevent warnings
Date: Thu, 01 Aug 2013 14:17:54 -0600 [thread overview]
Message-ID: <51FAC272.8040105@wwwdotorg.org> (raw)
In-Reply-To: <20130723154918.GB2864-RcKxWJ4Cfj3FNiLNb7+IINdj8bHVeoWogfoxzgwHRXE@public.gmane.org>
On 07/23/2013 09:49 AM, Thierry Reding wrote:
> On Sun, Jul 21, 2013 at 11:25:28PM +0200, Stefan Agner wrote:
>> The SoC specific code is in subdirectories which leads to
>> warnings in newer automake versions. The option subdir-objects
>> prevents those warnings.
>>
>> Signed-off-by: Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org> --- src/Makefile.am
>> | 2 ++ 1 file changed, 2 insertions(+)
>>
>> diff --git a/src/Makefile.am b/src/Makefile.am index
>> 6fcc0d8..6fecfc7 100644 --- a/src/Makefile.am +++
>> b/src/Makefile.am @@ -1,3 +1,5 @@ +AUTOMAKE_OPTIONS =
>> subdir-objects + AM_CFLAGS = -Wall -std=c99
>>
>> bin_PROGRAMS = cbootimage bct_dump
>
> Hi Stefan,
>
> Thanks for the patch. Generally this looks good to me, though
> automake now complains:
>
> src/Makefile.am:36: compiling `t114/parse_t114.c' in subdir
> requires `AM_PROG_CC_C_O' in `configure.ac'
>
> Which can quite easily be solved by adding that line in
> configure.ac. Immediately following the AC_PROG_CC looks like a
> good place for it.
Stefan, are you planning on revising the patch based on Thierry's
suggestion?
next prev parent reply other threads:[~2013-08-01 20:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-21 21:25 [PATCH tegra-cbootimage] Add automake option subdir-objects to prevent warnings Stefan Agner
[not found] ` <ba99c86b9074ac9053f665350e6b4985-XLVq0VzYD2Y@public.gmane.org>
2013-07-23 15:49 ` Thierry Reding
[not found] ` <20130723154918.GB2864-RcKxWJ4Cfj3FNiLNb7+IINdj8bHVeoWogfoxzgwHRXE@public.gmane.org>
2013-08-01 20:17 ` Stephen Warren [this message]
[not found] ` <51FAC272.8040105-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-08-19 20:08 ` Allen Martin
2013-08-19 20:18 ` Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FAC272.8040105@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=amartin-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=stefan-XLVq0VzYD2Y@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.